Prepare next release - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@germ-network/atprotoclient@0.8.0
Minor Changes
#46
be79b49Thanks @germ-mark! - Servecom.atproto.repo.createRecordfrom MockPDS. Same guards and body handling asputRecord, but the PDS mints the record key — a TID, so the key callers recover fromuriparses as one. A caller-suppliedrkeyis refused with a 400 rather than honored: without the already-exists failure modeled too, honoring it would just beputRecordunder another name. Production paths that create records (blocking, for one) were previously untestable against the mock: it 400'd on the way in.Fixes the record
urithe mock reports. Reads returnedat://did:web:example.com/NSID(rawValue: "app.bsky.graph.block")/<rkey>— a hardcoded authority, andcollectioninterpolated as a struct rather than itsrawValue— andputRecordreturned the bare placeholder"example.com". Every uri is now built in one place from the repo's own DID, so create, put and read all name the same record the same way.Fixes the
cidthatcreateRecordandputRecordreturn: it was the literal"mock", which does not parse as a CID (nobprefix, not base32), so feeding it back to anything that takes one failed at the boundary. It is nowAtproto.CID.mock().string, matching what reads already returned.Raises the GermConvenience floor to 0.3.0 and aligns the mock's errors with its cleaned-up handling. The mock's generic 400s said
"Invalid Request"— with a space, matching no atproto error name — soparsefell through and every one reached the caller as an opaque.unrecognized(400 ). They areInvalidRequestnow, which is indefaultErrors, so consumers get a typed.xrpcErrorthey can match on.getRecord'scatchmoved offHTTPResponseError.unsuccessfulString, which 0.3.0 no longer throws, onto the type plus itscode/bodyStringaccessors.Breaking:
MockRepo.inittakes the repo'sdid. Callers that construct aMockRepodirectly need updating;MockPDS.host(did:bskyProfile:)is unchanged. Anything asserting on the olduriorcidvalues, or matching a mock 400 as.unrecognized, needs updating too.The GermConvenience floor is the one to watch downstream: SwiftPM's
from:isupToNextMajoron 0.x, so this drags a consumer's whole graph onto 0.3.0, which is source-breaking for anything that mutates aBundledHTTPRequest. oauth4swift ≥ 0.6.0 carries its companion change; first-party mutation sites migrate tosettingHeader(_:for:).