Prepare bb-app 0.36.0 - #1173
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
🚨 SLOP COP 🚨 · I am the Slop Cop. I am reviewing this pull request under the security, quality, performance, architecture, and end-to-end guidelines. |
| The server used to listen on every network interface, which exposed its unauthenticated API to any host that could reach the machine. It now binds `127.0.0.1`. Use `--server-bind-host 0.0.0.0` or `BB_SERVER_BIND_HOST` to opt back in, only behind a trusted network boundary. | ||
|
|
||
| - **Action needed before you upgrade** if a browser or an enrolled machine reaches bb at a direct address such as `http://<LAN-IP>:38886` or `http://<machine>.<tailnet>.ts.net:38886`. Move the route first, then upgrade. This release also raises the host daemon protocol, so every enrolled daemon must update itself — and a daemon that lost its route cannot. | ||
| - Move to bb connect, or put bb behind Tailscale Serve, then remove and re-add each machine in Settings → Machines so its installer records the new route. Setup steps: https://github.com/get-bb/bb/blob/main/docs/multiple-devices.md |
There was a problem hiding this comment.
🚨 slopcop/review — The migration guide URL renders as plain text on /changelog.
This release note tells affected users to complete a required route migration. The browser test confirmed that the article contains no link for this URL. ChangelogInline supports only text, code, and strong text, so the browser cannot create an anchor. Please add safe link support and render these setup steps as a link.
SawyerHood
left a comment
There was a problem hiding this comment.
🚨 SLOP COP 🚨 · review
ELI5: This pull request prepares version 0.36.0 and adds its release notes. The version work is correct, but one important setup link does not work.
I found one concrete issue. The loopback migration guide appears as plain text on /changelog. Affected users cannot select it as a link. I left an inline comment with the required fix.
The security review found no new vulnerability. The change adds static release data and keeps React text escaping in place.
The end-to-end test passed. /changelog showed 0.36.0 first, the anchor worked, the homepage showed the new headline, and the browser reported no errors.
The parser completed in 0.27 ms. This release adds about 1.7 KB gzip to a shared marketing bundle because all routes include the full changelog. That architecture existed before this pull request. A later change should load the full changelog only for its route.
The repository scan found no stale release version and no duplicate release prose. The two package versions match, and the release metadata has its intended separate role.
All CI and package smoke checks pass. I used a comment-only review, as required.
Summary
Prepares the 0.36.0 release: version lockstep bump and release notes.
bb-appand@bb/desktopto0.36.0viascripts/bump-version.mjs0.36.0section toCHANGELOG.md0.36.0entry toRELEASE_METAinapps/web/src/landing/changelog.tsRelease notes
Headline is "Fixes and improvements". The notes lead with the loopback bind default (#1125), because it is the one change that needs user action before the upgrade. That section links to
docs/multiple-devices.mdfor the bb connect and Tailscale Serve setup steps rather than repeating them.Two risks are called out explicitly in the notes:
host:38886address loses its route and cannot self-update, so the route must move first.A Thanks section credits the external contributors in this range: @ben-vargas, @Diffuzmetall, @kschrader, and @toasterman234.
Commands stay as inline code spans throughout. The
/changelogparser handles only paragraphs and bullets, and its inline renderer supports onlycodeandstrong, so a fenced block or a Markdown link would render as literal text on the marketing site.Validation
node .github/workflows/check-version-lockstep.mjs— bb-app=0.36.0 @bb/desktop=0.36.0pnpm exec turbo run typecheck test --filter=@bb/config --filter=@bb/server --filter=bb-app --force— 1367 tests passedpnpm exec turbo run smoke:tarball --filter=bb-app --force— passedgit diff --check— cleanUnrelated pre-existing issue found while validating:
apps/server/test/internal/internal-skill-trees.test.tsasserts a file mode of0o644, which depends on the process umask. It fails underumask 002and passes underumask 022. CI is unaffected.Follow-ups
@bb/webafter this lands so/changelogshows 0.36.0.publish-bb-app.ymlandbuild-desktop.ymlstill need to run frommainat this commit.🤖 Generated with Claude Code