fix(app): restore dev WS URL rehosting lost in the workflows revert - #124
Closed
SawyerHood wants to merge 1 commit into
Closed
fix(app): restore dev WS URL rehosting lost in the workflows revert#124SawyerHood wants to merge 1 commit into
SawyerHood wants to merge 1 commit into
Conversation
The workflows revert (ee01a53) returned apps/app/src/lib/ws.ts and terminal-websocket-url.ts to a state predating da16d3c, silently undoing the dev WS rehost fix: remote devices (BB_DEV_APP_HOST=0.0.0.0, e.g. over tailscale) dialed the baked ws://localhost:<port> — their own loopback — so realtime updates never arrived and timelines only moved on refetch triggers (stop, send, refocus). Reapplies da16d3c's hunks verbatim: swap only the hostname of the baked dev URL for window.location.hostname on the realtime and terminal sockets. The intentional parts of the revert (dropping the workflow subscription refcounting) are untouched. Verified by loading the app via the tailnet IP with a live turn: the realtime socket now dials ws://<page-host>:<server-port>/ws and new turn output renders without any user interaction. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
Author
|
Superseded by #116 (cd954fd), which landed the same repair as an explicit opt-in: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The workflows revert (ee01a53) returned
apps/app/src/lib/ws.tsandterminal-websocket-url.tsto a state predating da16d3c, silently undoing the dev WS rehost fix as collateral damage.Symptom: on a remote device (
BB_DEV_APP_HOST=0.0.0.0, e.g. over tailscale), the app loads and/apiworks through the same-origin vite proxy, but the realtime socket dials the bakedws://localhost:<server-port>/ws— the device's own loopback — and never connects. No live updates arrive; timelines only move on refetch triggers (pressing stop, sending another message, window refocus). Provider-independent; it presents as "responses don't appear until I press stop and send another message."Fix
Reapplies da16d3c's hunks verbatim: swap only the hostname of the baked dev URL for
window.location.hostnameon the realtime and terminal sockets. The intentional parts of the revert (dropping workflow subscription refcounting in the same file) are untouched.Verification
turbo run typecheck --filter=@bb/app✅ws://<page-host>:20694/wsand a mid-conversation agent response rendered live (~8s) with no interaction.🤖 Generated with Claude Code