Skip to content

Sync terminal tabs and active badge counts - #127

Closed
ymichael wants to merge 3 commits into
mainfrom
bb/count-active-terminals-only-thr_t5tt4qhpj2
Closed

Sync terminal tabs and active badge counts#127
ymichael wants to merge 3 commits into
mainfrom
bb/count-active-terminals-only-thr_t5tt4qhpj2

Conversation

@ymichael

@ymichael ymichael commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • add domain helpers for active vs visible terminal session statuses
  • count only starting/running terminal sessions in the thread header badge
  • render right-panel terminal tabs from the server session list so multiple clients stay in sync while preserving local tab order where possible
  • materialize synced terminal tabs into local fixed-panel state so selection/reorder/close behavior converges after terminal query data lands
  • drop stale local terminal tabs when another client closes/removes the session
  • align mobile text tab pills with the icon-only Info/Diff controls

Validation

  • pnpm exec turbo run test --filter=@bb/domain
  • pnpm exec turbo run typecheck --filter=@bb/domain --filter=@bb/app
  • pnpm exec turbo run lint --filter=@bb/app
  • pnpm exec turbo run test --filter=@bb/app
  • pnpm exec turbo run typecheck --filter=@bb/app
  • pnpm exec turbo run lint --filter=@bb/app

@ymichael ymichael changed the title Count only active terminal sessions in badge Sync terminal tabs and active badge counts Jun 12, 2026
@ymichael ymichael mentioned this pull request Jun 12, 2026
Merged
@ymichael ymichael closed this Jun 13, 2026
ymichael added a commit that referenced this pull request Jun 13, 2026
@ymichael
Refactor secondary panel tab ownership (#131)
871951c 
## Summary
- unify secondary-panel tab state behind stable identities and derive
panel open state from tab state
- remove secondary-panel URL round-trip sync and per-kind file-tab
callback plumbing
- make browser view visibility deck-local and preserve diff/iframe
mounts across visibility toggles
- reducerize git diff panel state and fold in #127 terminal tab sync /
active-count changes

## Validation
- pnpm exec turbo run typecheck --filter=@bb/app --filter=@bb/domain
- pnpm exec turbo run test --filter=@bb/app -- threadTerminalTabs
gitDiffPanelStateReducer secondaryPanelTabState
- pnpm exec turbo run test --filter=@bb/domain -- terminal
- git diff --check
@yegor-korobeynikov yegor-korobeynikov mentioned this pull request Aug 26, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ymichael