Skip to content

Polish machine Settings hierarchy - #1935

Closed
brsbl wants to merge 1 commit into
bb/updates-by-machine-thr_qwah76hjqrfrom
bb/machine-settings-hierarchy-thr_qwah76hjqr
Closed

Polish machine Settings hierarchy#1935
brsbl wants to merge 1 commit into
bb/updates-by-machine-thr_qwah76hjqrfrom
bb/machine-settings-hierarchy-thr_qwah76hjqr

Conversation

@brsbl

@brsbl brsbl commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • align Machines list and detail hierarchy with the updated Settings surfaces
  • simplify Add Machine while preserving enrollment behavior
  • add navigable row treatment, accessible machine/permission status, provider logos, and a content-sized action menu
  • keep Rename and Remove behavior intact, with the primary-machine removal reason moved to a tooltip

Depends on the Settings chrome and shared atoms introduced by the parent Updates layer.

Visual evidence

Machines list before:

Before: Machines list

Machines list after:

After: Machines list

Machine detail before:

Before: Machine detail

Machine detail after:

After: Machine detail

Verification

  • Turbo typecheck: @bb/app
  • Add Machine, Machines list/detail, and relative-time tests: 25 passed
  • real dev app checked at 390×844, 768×900, 1440×900, and 3440×1440

BB-Thread-ID: thr_qwah76hjqr

AGENT GENERATED: by GPT-5.6

@brsbl
brsbl force-pushed the bb/machine-settings-hierarchy-thr_qwah76hjqr branch from cea81ab to 049bb4e Compare August 19, 2026 16:35
@brsbl
brsbl force-pushed the bb/machine-settings-hierarchy-thr_qwah76hjqr branch from 049bb4e to 24de523 Compare August 19, 2026 17:02
@brsbl
brsbl force-pushed the bb/machine-settings-hierarchy-thr_qwah76hjqr branch from 24de523 to 1ce758b Compare August 19, 2026 17:07
@brsbl
brsbl force-pushed the bb/machine-settings-hierarchy-thr_qwah76hjqr branch from 1ce758b to fcd39dd Compare August 19, 2026 19:00
brsbl added a commit that referenced this pull request Aug 20, 2026
## Summary

- group update inventory by machine and keep provider, bb app, state,
badge, action, and changelog behavior coherent
- align Machines list and detail hierarchy with Updates using existing
settings rows, icons, menus, and tooltips
- add chrome-wrapped, navigable Settings and Updates Ladle coverage,
including all update states
- gate the changelog preview behind the existing experiments system
- keep the existing full experiments contract; no compatibility shim or
new endpoint

Supersedes #1933, #1934, #1935, #1936, and #1947 with one reviewable
change based on current main.

## Visual evidence

Exact base: 6b7c58f  
Exact head: 964709d

### Updates — desktop 1440×900

Before:

![Updates before at
1440×900](https://raw.githubusercontent.com/get-bb/bb/f87828332f6540f4c2f927511ab99dae487dd4be/evidence/settings-updates-machines/base-final-updates-1440.png)

After:

![Updates after at
1440×900](https://raw.githubusercontent.com/get-bb/bb/f87828332f6540f4c2f927511ab99dae487dd4be/evidence/settings-updates-machines/after-final-updates-1440.png)

### Updates — compact desktop 768×900

Before:

![Updates before at
768×900](https://raw.githubusercontent.com/get-bb/bb/f87828332f6540f4c2f927511ab99dae487dd4be/evidence/settings-updates-machines/base-final-updates-768.png)

After:

![Updates after at
768×900](https://raw.githubusercontent.com/get-bb/bb/f87828332f6540f4c2f927511ab99dae487dd4be/evidence/settings-updates-machines/after-final-updates-768.png)

### Machines — desktop 1440×900

Before:

![Machines before at
1440×900](https://raw.githubusercontent.com/get-bb/bb/f87828332f6540f4c2f927511ab99dae487dd4be/evidence/settings-updates-machines/base-final-machines-1440.png)

After:

![Machines after at
1440×900](https://raw.githubusercontent.com/get-bb/bb/f87828332f6540f4c2f927511ab99dae487dd4be/evidence/settings-updates-machines/after-final-machines-1440.png)

### Machines — compact desktop 768×900

Before:

![Machines before at
768×900](https://raw.githubusercontent.com/get-bb/bb/f87828332f6540f4c2f927511ab99dae487dd4be/evidence/settings-updates-machines/base-final-machines-768.png)

After:

![Machines after at
768×900](https://raw.githubusercontent.com/get-bb/bb/f87828332f6540f4c2f927511ab99dae487dd4be/evidence/settings-updates-machines/after-final-machines-768.png)

## Validation

- 56 focused app tests passed
- 36 focused server tests passed
- domain experiment tests passed
- 812 mobile tests and mobile typecheck passed
- plugin-registry generated-artifact test and typecheck passed
- Turbo typecheck passed for app, server, CLI, domain, server-contract,
and desktop
- exact main/head Settings → Updates and Settings → Machines states
checked at 1440×900 and 768×900

BB-Thread-ID: thr_qwah76hjqr

> AGENT GENERATED: by GPT-5.6
@brsbl

brsbl commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #1996, which consolidated this stack onto current main and is now merged.

@brsbl brsbl closed this Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant