Ban non-semantic code comments - #2624
Merged
SawyerHood merged 1 commit intoAug 28, 2026
Merged
Conversation
SawyerHood
deleted the
bb/delete-typescript-comments-codemod-thr_pz28rvtnwb
branch
August 28, 2026 03:57
ymichael
added a commit
that referenced
this pull request
Aug 31, 2026
…omments Land the dispatch-queue rework on main's newer trunk: - HOST_DAEMON_PROTOCOL_VERSION resolves to 176 (main's 175 + 1) with the branch narration reduced to the one thing a daemon observes: the three branch-only `system/*` event types leaving `threadEventSchema`. Main deleted the historical narration block, so the file keeps main's shape. - @get-bb/plugin-sdk bumped 0.4.30 -> 0.4.31 via scripts/bump-plugin-sdk.mjs (main had moved past the branch's stale 0.4.33 lineage); bundled types, sdk-public-api.json and the plugin registry snapshots regenerated. - thread-create uses main's resolveManagedBaseBranchForCreate shape; #2616 removed resolveManagedNamedBaseBranchSpec and the originKind arm. - Composer queue UI adopts main's "follow-up" wording (#2695) while keeping the branch's queue rows, wait lines and visuals. - The bb-cli and bb-plugin-authoring skills were restructured on main into references/; the branch's CLI surface (`--send-at`, queued delivery, `bb thread count`, `bb thread retry`) and plugin surface (`bb.experimental_hooks`, `message.queued`/`message.dispatched`/ `turn.failed`, the new SDK type exports) are documented there instead. - apps/app comments removed to satisfy main's `bb/no-comments` rule (#2624). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ymichael
added a commit
that referenced
this pull request
Aug 31, 2026
…omments Land the dispatch-queue rework on main's newer trunk: - HOST_DAEMON_PROTOCOL_VERSION resolves to 176 (main's 175 + 1) with the branch narration reduced to the one thing a daemon observes: the three branch-only `system/*` event types leaving `threadEventSchema`. Main deleted the historical narration block, so the file keeps main's shape. - @get-bb/plugin-sdk bumped 0.4.30 -> 0.4.31 via scripts/bump-plugin-sdk.mjs (main had moved past the branch's stale 0.4.33 lineage); bundled types, sdk-public-api.json and the plugin registry snapshots regenerated. - thread-create uses main's resolveManagedBaseBranchForCreate shape; #2616 removed resolveManagedNamedBaseBranchSpec and the originKind arm. - Composer queue UI adopts main's "follow-up" wording (#2695) while keeping the branch's queue rows, wait lines and visuals. - The bb-cli and bb-plugin-authoring skills were restructured on main into references/; the branch's CLI surface (`--send-at`, queued delivery, `bb thread count`, `bb thread retry`) and plugin surface (`bb.experimental_hooks`, `message.queued`/`message.dispatched`/ `turn.failed`, the new SDK type exports) are documented there instead. - apps/app comments removed to satisfy main's `bb/no-comments` rule (#2624). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ymichael
added a commit
that referenced
this pull request
Sep 1, 2026
…omments Land the dispatch-queue rework on main's newer trunk: - HOST_DAEMON_PROTOCOL_VERSION resolves to 176 (main's 175 + 1) with the branch narration reduced to the one thing a daemon observes: the three branch-only `system/*` event types leaving `threadEventSchema`. Main deleted the historical narration block, so the file keeps main's shape. - @get-bb/plugin-sdk bumped 0.4.30 -> 0.4.31 via scripts/bump-plugin-sdk.mjs (main had moved past the branch's stale 0.4.33 lineage); bundled types, sdk-public-api.json and the plugin registry snapshots regenerated. - thread-create uses main's resolveManagedBaseBranchForCreate shape; #2616 removed resolveManagedNamedBaseBranchSpec and the originKind arm. - Composer queue UI adopts main's "follow-up" wording (#2695) while keeping the branch's queue rows, wait lines and visuals. - The bb-cli and bb-plugin-authoring skills were restructured on main into references/; the branch's CLI surface (`--send-at`, queued delivery, `bb thread count`, `bb thread retry`) and plugin surface (`bb.experimental_hooks`, `message.queued`/`message.dispatched`/ `turn.failed`, the new SDK type exports) are documented there instead. - apps/app comments removed to satisfy main's `bb/no-comments` rule (#2624). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
The repository allowed explanatory code comments without a common removal tool or a lint check.
What changed
bb/no-commentsOxlint rule and enabled it for the repository.AGENTS.md.How you verified
pnpm run codemod:remove-typescript-commentsremoved zero comments on a second run.pnpm exec turbo run lintpnpm exec turbo run typecheckpnpm exec turbo run test --filter=@get-bb/plugin-sdk --forcepnpm exec turbo run test --filter=@bb/mobile --forcenode packages/plugin-registry/scripts/build-registry.mjs --checkgit diff --check