Fix mobile file tab close spacing - #2798
Merged
Merged
Conversation
Offset file-tab labels when coarse-pointer close targets expand so the 36px touch target no longer overlaps the filename.
ymichael
deleted the
bb/fix-mobile-tab-trigger-styling-thr_q2ws2irggv
branch
September 1, 2026 15:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
File-preview tabs enlarge their close target to 36px on narrow coarse-pointer screens, but the selectable tab trigger retained its 6px desktop left inset. Centering the close glyph in that wider target moved it over the filename: the glyph ended at x=122 while the label began at x=120, producing a 2px overlap.
What changed
How you verified
pnpm exec turbo run test --filter=@bb/app --force -- --run src/components/ui/tab-pill.test.tsx(5 tests passed).pnpm exec turbo run typecheck --filter=@bb/app --force.BB-Thread-ID: thr_q2ws2irggv