Disable Electron spellcheck and background throttling - #2934
Open
Guitaraholic wants to merge 1 commit into
Open
Conversation
bb is a control plane, not a document editor. Spellcheck walks the DOM on input. Background throttling pauses token streams and query refetch when the window is occluded. Fixes get-bb#2693
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Chromium's spellchecker walks the DOM on input, which is wasted work in a control-plane UI. With
backgroundThrottlingon, token streams, reconnect timers, and query refetch stall when the desktop window is occluded. Root cause of the main-thread cost in #2693.What changed
webPreferences.spellcheck: falseandsession.setSpellCheckerEnabled(false)on window create and context-menu register.webPreferences.backgroundThrottling: false.HOST_DAEMON_PROTOCOL_VERSIONchange. Remote-first startup was already correct and is unchanged.How you verified
apps/desktop/test/desktop-window-factory.test.tsanddesktop-context-menu.test.tsfail before (spellcheck/throttling expected true) and pass after.Fixes #2693