Fix collapsed preview overflow render loop - #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
A collapsed child-thread preview could fit without its manual
...marker but overflow after the marker was mounted. The overflow measurement then removed the marker, which made the preview fit again and caused an infinite ResizeObserver/render loop.Browser profiling on the affected workspace measured 364 DOM mutations and 4.62 seconds of style recalculation over five seconds at roughly 18 FPS. Reserving the marker width reduced that sample to zero mutations, 0.033 seconds of style recalculation, and 60 FPS.
Validation
pnpm exec turbo run typecheck --filter=@bb/apppnpm exec turbo run test --filter=@bb/app -- --run src/components/thread/timeline/GeneratedConversationMessage.test.tsxpnpm exec turbo run test --filter=@bb/app --force(241 files, 1,601 tests)