fix: guard against duplicate teardown from repeated Stop toggles _fadeOutWrapThenStop() scheduled a new setTimeout(stopSplitScreen) on every call, but active doesn't flip false until that timeout fires — so a second toggle() while the fade was in flight queued a second stopSplitScreen()/teardownPanels() run against already-torn-down state. Track the pending timer and no-op repeat calls; stopSplitScreen clears it too, so a direct (non-fade) stop can't leave a stale timer to fire against a later session. Also strengthens two existing tests per review: the multi-panel layout test now asserts each grid's cols*rows actually covers its panel count, and the _bestFitLayout test adds the n=2 case. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NzB8E8ExunXPfJzNotqkx4 - #15
Merged
Conversation
_fadeOutWrapThenStop() scheduled a new setTimeout(stopSplitScreen) on every call, but active doesn't flip false until that timeout fires — so a second toggle() while the fade was in flight queued a second stopSplitScreen()/teardownPanels() run against already-torn-down state. Track the pending timer and no-op repeat calls; stopSplitScreen clears it too, so a direct (non-fade) stop can't leave a stale timer to fire against a later session. Also strengthens two existing tests per review: the multi-panel layout test now asserts each grid's cols*rows actually covers its panel count, and the _bestFitLayout test adds the n=2 case. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NzB8E8ExunXPfJzNotqkx4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.