Local

[carochacs]

What

feedpak surface

• This PR does not change how the app reads/writes feedpaks (manifest keys, pack files, folder layout)
• …or it does, and the spec change landed first via the FEP process — FEP / spec PR: got-feedback/feedpak-spec#___ (once it merges, re-run this PR's checks and the gate goes green)

Checklist

• CHANGELOG.md [Unreleased] updated (user-visible changes)
• Tests added/updated for new behaviour
• Commits are DCO signed off (git commit -s)

[coderabbitai]

📝 Walkthrough

Walkthrough

Changes

Arrangement typing and highway selection

Layer / File(s)	Summary
Arrangement type classification and propagation lib/gp2rs_gpx.py, lib/routers/ws_highway.py	Keyboard tracks are classified as keys before guitar tracks. Normalized arrangement types are included in highway metadata and selected-arrangement payloads.
Authoritative type checks for naming and matching lib/song.py, plugins/highway_3d/screen.js	Manifest types prevent non-lead instruments from entering fallback name grouping. Highway matching excludes keys arrangements before keyword matching.

Highway chord orientation

Layer / File(s)	Summary
Fixed chord diagram orientation plugins/highway_3d/screen.js, plugins/highway_3d/plugin.json, plugins/highway_3d/CLAUDE.md, CHANGELOG.md	Chord diagrams always use non-inverted orientation. The plugin version, documentation, and changelog were updated.

Stems reroute transport handling

Layer / File(s)	Summary
Reroute playback-state guards static/app.js, static/js/transport.js	Playback events and transport rejection handling ignore transient stems reroute activity.

Repository ignore rules

Layer / File(s)	Summary
Generated path exclusions .gitignore	The repository ignores /library and /static/sloppak_cache.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant GPXSelector
  participant Song
  participant HighwayWebSocket
  participant HighwayScreen
  GPXSelector->>Song: Classify keyboard tracks as keys
  Song->>HighwayWebSocket: Provide normalized arrangement type
  HighwayWebSocket->>HighwayScreen: Send arrangement_type and arrangement metadata
  HighwayScreen->>HighwayScreen: Reject keys before name matching

Loading

Suggested reviewers: byrongamatos, chrisbewithyou

---

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

• Ignore

❌ Failed checks (1 error, 1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❌ Error	The template is present, but the What section is empty and the feedpak, tests, and DCO checklist items are unresolved.	Describe the changes and rationale, select the applicable feedpak option, and confirm tests and DCO sign-off status.
Blocking Route Handlers Use Def Not Async	⚠️ Warning	The modified async highway_ws directly calls convert_wem at lines 459 and 481; convert_wem performs synchronous subprocess audio conversion without an executor wrapper.	Wrap both convert_wem calls and related blocking work in run_in_executor/asyncio.to_thread, or make the handler a synchronous def dispatched through the executor.
Title check	❓ Inconclusive	The title “Local” is too vague to identify the pull request’s primary changes.	Replace “Local” with a concise title that names the main changes, such as instrument-type handling and stems reroute playback guards.

✅ Passed checks (19 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Plugin Folder Name Matches Manifest Id	✅ Passed	The touched manifest is plugins/highway_3d/plugin.json; its id is exactly "highway_3d", matching the containing directory name character-for-character.
No Print()/Console.Log In Routes.Py	✅ Passed	The PR adds no print(...) or traceback.print_exc(...) lines in changed Python files; no routes.py or setup(app, context) is modified, and route imports contain no such calls.
Sibling Imports Use Load_sibling	✅ Passed	The PR changes no plugin Python modules; its only plugin changes are documentation, JSON, and screen.js, so it adds no sibling import requiring load_sibling.
Routes Namespaced Under /Api/Plugins/Id	✅ Passed	AST audit found every registered HTTP route under /api/plugins/<plugin.json id>/; folder_library uses an effective prefixed APIRouter, and no plugin WebSocket routes exist.
Plugin.Json Version Bumped On Change	✅ Passed	The PR changes functional plugins/highway_3d/screen.js and bumps plugin.json from valid semver 3.34.1 to strictly greater 3.34.2.
No Per-Frame Dom Queries In Draw/Raf	✅ Passed	Modified JS has no exact draw function or MutationObserver; rAF callbacks and the 16.67ms interval contain no document.querySelector/querySelectorAll calls.
Shortcuts Unregistered With Matching Scope	✅ Passed	The PR diff adds no registerShortcut call; the existing player-scoped tuner registration is unchanged from the base commit, so this check is not applicable.
Idempotent Guard On Top-Level Listeners	✅ Passed	The PR's screen.js diff adds no addEventListener, setInterval, playSong, or showScreen call; its changes only set chord inversion and filter keys arrangements.
Server_files Entries Are Safe Relpaths	✅ Passed	The only plugin.json diff changes the version; its server_files entries are relative, use forward slashes, contain no '..' or leading dot segment, and do not start with '/'.
Setrenderer Factory Has Init/Draw/Destroy	✅ Passed	The renderer factory returns init(canvas,bundle), draw(bundle), and destroy(). initScene mounts WebGL/overlay resources and listeners; destroy calls teardown, removes them, disposes WebGL, and null...
Overlay Gates On Isdefaultrenderer Instructions	✅ Passed	The PR adds no highway.project(...) or highway.fretX(...) positioning calls; it only changes chord overlay options to inverted:false, so the conditional renderer gate and RAF checks do not apply.
V3 Ui Mounts Via Playercontrolslot	✅ Passed	The PR adds no #player-controls lookup or DOM insertion code; added JavaScript lines only guard reroute events and update highway rendering.
New Feedpak Manifest Keys Declared In Spec	✅ Passed	The PR does not modify manifest readers or writers; it uses pre-existing arrangement type, which current-main feedpak schemas declare under arrangementEntry.
Feedpak Manifest Required Keys Present	✅ Passed	The PR diff has no feedpak/feedpakr path and does not touch manifest assembly; changed code only reads manifest metadata or writes GP XML.
Changelog Unreleased Section Updated	✅ Passed	The PR changes application behavior and adds a new highway_3d fix bullet under CHANGELOG.md [Unreleased] → Fixed, using Keep a Changelog structure.
New Python Modules Have Pytest Coverage	✅ Passed	The PR diff adds no new Python files. It only modifies existing Python modules, so the new-module pytest coverage check is not applicable.
No Hardcoded Secrets Or Tokens In Diff	✅ Passed	The 59 added lines contain no AWS AKIA keys, PEM private-key headers, or TOKEN/SECRET/API_KEY/PASSWORD assignments with literal values.

✨ Finishing Touches 💡 1

⚔️ Resolve merge conflicts 💡

• Resolve merge conflict in branch local

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch local

---

_{Comment @coderabbitai help to get the list of available commands.}