fix: prevent state updates in parent while rendering qrcodescanner#196
Merged
im-adithya merged 1 commit intomasterfrom Nov 22, 2024
Merged
fix: prevent state updates in parent while rendering qrcodescanner#196im-adithya merged 1 commit intomasterfrom
im-adithya merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue
This is logged when a QR is scanned:
Warning: Cannot update a component (SetupWallet) while rendering a different component (QRCodeScanner). To locate the bad setState() call inside QRCodeScanner, follow the stack trace as described in https://reactjs.org/link/setstate-in-renderThe fix
Updater functions run during rendering, and that causes state updates in the parent as we are calling
onScanned, so this moves that out to checkisScanningand then proceed so that the logic is same but it is just moved outside the updater function