feat: link to node page from healthcheck indicator and show healthcheck alert #1202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumi
reviewed
Mar 19, 2025
Contributor
Author
|
I realized with changing the healthcheck indicator to link to the node page we have issues with Cashu and Phoenixd. I have proposed a fix to merge into this branch here: #1210 |
Co-authored-by: Michael Bumann <hello@michaelbumann.com>
Fixes #1206 I did the same fix as we have for LND, that instead we only fetch the node info once on startup. In #1202 we link to the node page, which needs changes for Phoenixd and Cashu so they cannot access channel-related pages/features. 
Contributor
Author
|
Real screenshot:
|
Contributor
Author
This will still show as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1178
Rather than showing a toast when hovering over the healthcheck, it links to the node page. By default the node page will only show an alert if the healthcheck is failing, however if they click on the green healthcheck indicator, it'll show a success alert.
Now the alby services with incidents will show along with their status, and we link directly to the alby status page and a guide where the user can learn more.