fix: return offline channel balance in get_balance nwc call #1217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1183
We introduce a new internal variable called
includeInactiveChannelsin theLNClientGetBalancescall. But we only set it to true in theGetBalancesControllerso that we only return offline channel balance externally (so as to not trouble the user).Internally (in the Hub) they'll see the reduced balance but the user will anyways be informed about their offline channel from the indicator so it shouldn't be an issue.
Testing
Tested in both LND and LDK by disconnecting peers. NWC
get_balanceincludes offline channel balances as well as intended 👍