Skip to content

Conversation

@rolznz
Copy link
Contributor

@rolznz rolznz commented Mar 26, 2025

Fixes #1197 (LDK only)

Adds new properties to the nwc_channel_closed event for both LDK and LND:

counterparty_node_url

Adds new properties to the nwc_channel_closed event to LDK only:

pending_balance
funding_tx_id
funding_tx_vout
funding_tx_url

CC @MoritzKa (to review the new event properties which we could show in the email)

@rolznz rolznz requested a review from im-adithya March 26, 2025 09:00
Copy link
Member

@im-adithya im-adithya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@rolznz rolznz merged commit 0cd8296 into master Mar 27, 2025
11 checks passed
@rolznz rolznz deleted the feat/nwc-channel-closed-funding-txid-amount branch March 27, 2025 05:35
@MoritzKa
Copy link
Contributor

MoritzKa commented Apr 9, 2025

I created this copy and added the pending_balance information. I think it is more useful than the opening transaction, isn't it?

@rolznz
Copy link
Contributor Author

rolznz commented Apr 9, 2025

@MoritzKa I think the opening tx is still useful for reference. Could we include it underneath the pending balance? or do you see some downside? (I know it's not optimal, but it's what we have)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include incoming balance in channel closure email

4 participants