fix: always show swap alert on close channel dialog #1227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im-adithya
approved these changes
Mar 26, 2025
Member
im-adithya
left a comment
im-adithya
left a comment
There was a problem hiding this comment.
tACK, but just faced another issue (unrelated to the changes in this PR). If you open the Swap In modal and then close it and try to open it again, it doesn't work (since we are already on /channels?swap=true)
Contributor
Author
|
Ah, this also does not work well. Thanks for catching this @im-adithya I pushed a fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if the user has 1 channel there's no need to close it when they could swap instead