Skip to content

fix: clarify connected peers navigation in LDK alert#2250

Merged
im-adithya merged 1 commit into
getAlby:masterfrom
hermes-alby:fix/issue-2249-connected-peers-copy
Apr 21, 2026
Merged

fix: clarify connected peers navigation in LDK alert#2250
im-adithya merged 1 commit into
getAlby:masterfrom
hermes-alby:fix/issue-2249-connected-peers-copy

Conversation

@hermes-alby
Copy link
Copy Markdown
Contributor

@hermes-alby hermes-alby commented Apr 21, 2026

Summary

  • update the LDK disconnected-peer alert to mention the Advanced menu
  • rename the destination from Peers to Connected Peers to match the current UI
  • tighten the wording from "re-connect" to "reconnect"

Testing

  • cd frontend && corepack yarn prepare:http
  • cd frontend && corepack yarn lint

Closes #2249

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Updated alert instructions to correctly guide users to the Advanced section and Connected Peers option when reconnecting peers.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ccda337a-1de5-428b-abaa-86e5770b17a7

📥 Commits

Reviewing files that changed from the base of the PR and between 963c7e1 and bcd5787.

📒 Files selected for processing (1)
  • frontend/src/components/channels/LDKChannelWithoutPeerAlert.tsx

📝 Walkthrough

Walkthrough

Updated alert instructions in the LDKChannelWithoutPeerAlert component to improve user navigation. Step 2 now directs users to open Advanced and click Connected Peers instead of directly opening Peers, with a minor phrasing adjustment from "re-connect" to "reconnect."

Changes

Cohort / File(s) Summary
Alert Instruction Updates
frontend/src/components/channels/LDKChannelWithoutPeerAlert.tsx
Modified step 2 instructions to guide users through the Advanced section to access Connected Peers, replacing direct "Peers" reference and standardizing hyphenation in "reconnect."

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A hop through Advanced we go today,
Connected Peers now light the way,
Clear instructions, easier to see,
Users finding joy, happy as can be! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: clarify connected peers navigation in LDK alert' is clear, specific, and directly describes the primary change: clarifying navigation instructions in the LDK alert component.
Linked Issues check ✅ Passed The pull request fully addresses issue #2249 by updating alert text to direct users to open Advanced menu and click Connected Peers instead of just opening Peers, and changes 're-connect' to 'reconnect'.
Out of Scope Changes check ✅ Passed The pull request contains only the intended changes to LDKChannelWithoutPeerAlert.tsx alert instructions with no extraneous modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@reneaaron reneaaron self-requested a review April 21, 2026 14:57
Copy link
Copy Markdown
Member

@im-adithya im-adithya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@im-adithya im-adithya merged commit d4bd46f into getAlby:master Apr 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve LDKChannelWithoutPeerAlert.tsx

2 participants