Skip to content

feat: simplify onchain receive routing#2268

Merged
im-adithya merged 3 commits intomasterfrom
feat/wallet-onchain-follow-up
May 1, 2026
Merged

feat: simplify onchain receive routing#2268
im-adithya merged 3 commits intomasterfrom
feat/wallet-onchain-follow-up

Conversation

@im-adithya
Copy link
Copy Markdown
Member

@im-adithya im-adithya commented Apr 29, 2026

This brings the on-chain receive from on-chain/other crypto screen to the main Receive screen so that we can navigate easily with the new on-chain mode

Summary by CodeRabbit

Release Notes

  • New Features

    • Added on-chain Bitcoin receiving with QR code generation and transaction monitoring.
    • Added lightning address receiving interface with dedicated navigation options.
    • Introduced tabbed receive interface to switch between spending and on-chain receiving flows.
  • Refactor

    • Reorganized receive flow routes to use query parameters for improved navigation structure.

@im-adithya im-adithya requested review from reneaaron and rolznz April 29, 2026 18:11
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 29, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR restructures the on-chain receive flow by changing URL routing from path-based to query-parameter-based, creating dedicated components for on-chain and spending receive flows, refactoring the main Receive screen to use tab-based UI, and simplifying ReceiveOnchain to focus on swap flows.

Changes

Cohort / File(s) Summary
Navigation Route Updates
frontend/src/components/CommandPalette.tsx, frontend/src/components/OnchainTransactionsList.tsx, frontend/src/screens/wallet/Onchain.tsx
Updated on-chain receive navigation routes from /wallet/receive/onchain to /wallet/receive?type=onchain (query-parameter-based routing).
New Receive Components
frontend/src/components/ReceiveToOnchain.tsx, frontend/src/components/ReceiveToSpending.tsx
Added new components: ReceiveToOnchain generates on-chain Bitcoin addresses, monitors mempool UTXOs, and renders QR code with state transitions (loading → address → pending → success); ReceiveToSpending displays lightning address QR code with copy/invoice/offer navigation options.
Receive Screen Refactoring
frontend/src/screens/wallet/Receive.tsx, frontend/src/screens/wallet/receive/ReceiveOnchain.tsx
Refactored Receive.tsx to implement tab-based UI controlled by type query parameter, delegating on-chain and spending flows to dedicated components; simplified ReceiveOnchain.tsx by removing on-chain receive UI and retaining only the spend-to-receive swap flow logic.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

Suggested reviewers

  • rolznz
  • reneaaron

Poem

🐰 Refactoring hops through the receive cascade,
Paths transform to params in query's parade,
Components extracted, states dance anew,
ReceiveToOnchain spins mempool's debut!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: simplifying onchain receive routing from path-based to query-parameter-based routes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/wallet-onchain-follow-up

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

Base automatically changed from feat/wallet-onchain-tx-list to master April 30, 2026 12:30
@reneaaron reneaaron force-pushed the feat/wallet-onchain-follow-up branch from 27f9a1d to 443216a Compare April 30, 2026 13:11
@im-adithya im-adithya merged commit 663b805 into master May 1, 2026
11 of 12 checks passed
@im-adithya im-adithya deleted the feat/wallet-onchain-follow-up branch May 1, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant