chore: bump lnd to v0.20.1-beta#2285
Conversation
📝 WalkthroughWalkthroughThe pull request updates ChangesDependency Management
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 267: The protobuf-go replacement version is out of sync with the lnd
bump: update the replacement that pins the protobuf module (the entry currently
ending with v1.30.0-hex-display) to v1.33.0-hex-display so it matches the
github.com/lightningnetwork/lnd v0.20.1-beta requirement; locate the go.mod
replacement for the protobuf module (the line referencing the hex-display
variant) and change its version suffix to v1.33.0-hex-display.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 298d739c-9ef2-4131-9326-0b05f82f9ad0
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| github.com/kelseyhightower/envconfig v1.4.0 | ||
| github.com/labstack/echo-jwt/v4 v4.4.0 | ||
| github.com/lightningnetwork/lnd v0.20.0-beta.rc4 | ||
| github.com/lightningnetwork/lnd v0.20.1-beta |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
For github.com/lightningnetwork/lnd v0.20.1-beta, what version/range of google.golang.org/protobuf is required in its go.mod, and are there known incompatibilities with protobuf-go forks pinned around v1.30.0?
💡 Result:
For github.com/lightningnetwork/lnd v0.20.1-beta, the required google.golang.org/protobuf version is pinned via go.mod to v1.33.0-hex-display (via a replace to a LightningLabs fork), rather than a google.golang.org/protobuf upstream semver range. Regarding incompatibilities with protobuf-go forks pinned around v1.30.0: I did not find any authoritative, source-backed report describing specific incompatibilities between lnd v0.20.1-beta and protobuf-go forks pinned to ~v1.30.0. The available evidence I found indicates lnd uses a forked/proxied google.golang.org/protobuf dependency (v1.33.0-hex-display), but it does not document (or I could not locate) known incompatibility details versus v1.30.0-pinned forks.
Citations:
- 1: https://github.com/lightningnetwork/lnd/blob/master/go.mod
- 2: https://github.com/lightningnetwork/lnd/tree/v0.20.1-beta.rc1/go.mod
🏁 Script executed:
# Check the go.mod file around line 277 to confirm the protobuf replacement
sed -n '270,280p' go.modRepository: getAlby/hub
Length of output: 461
Update protobuf-go-hex-display version to match lnd v0.20.1-beta requirement.
The protobuf replacement is currently pinned to v1.30.0-hex-display, but lnd v0.20.1-beta requires v1.33.0-hex-display. Update line 277 to pin v1.33.0-hex-display to ensure compatibility with the bumped lnd version and align with its declared dependencies.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` at line 267, The protobuf-go replacement version is out of sync with
the lnd bump: update the replacement that pins the protobuf module (the entry
currently ending with v1.30.0-hex-display) to v1.33.0-hex-display so it matches
the github.com/lightningnetwork/lnd v0.20.1-beta requirement; locate the go.mod
replacement for the protobuf module (the line referencing the hex-display
variant) and change its version suffix to v1.33.0-hex-display.
Bumps github.com/lightningnetwork/lnd from 0.20.0-beta.rc4 to 0.20.1-beta (Latest release)
Summary by CodeRabbit