Feat: update to v0.6.2#80
Merged
Merged
Conversation
We bump the `electrum-client` dependency to the recently-introduced version v0.24.0.
The just-released rustc 1.89 added a new `mismatched-lifetime-syntaxes` lint which had two warnings pop up. We fix these here.
…m-breakage-0.1 Bump `electrum-client` to v0.24.0 (0.6 release branch)
The `rustls` library recently introduced this weird behavior where they expect users to, apart from configuring the respective feature, also explictly call `CryptoProvider::install_default`. Otherwise they'd simply panic at runtime whenever the first network call requiring TLS would be made. While we already made a change upstream at `rust-electrum-client`, we also make sure here that we definitely, always, absolutley are sure that we have a `CryptoProvider` set on startup.
…crypto-provider Ensure we always startup with a `rustls` `CryptoProvider`
Previously, we had to configure enormous syncing timeouts as the BDK wallet syncing would hold a central mutex that could lead to large parts of event handling and syncing locking up. Here, we drop the configured timeouts considerably across the board, since such huge values are hopefully not required anymore.
Previously, we used to a channel to indicate that the background processor task has been stopped. Here, we rather just await the task's `JoinHandle` which is more robust in that it avoids a race condition.
.. we provide finer-grained logging after each step of `stop`.
Previously, we'd only wait for the background processor tasks to successfully finish. It turned out that this could lead to races when the other background tasks took too long to shutdown. Here, we attempt to wait on all background tasks shutting down for a bit, before moving on.
.. as tokio tends to panic if dropping a runtime in an async context and we're not super careful. Here, we add some test coverage for this edge case in Rust tests.
…or-0.6.2 Backports for 0.6.2
Cut v0.6.2 release
Maven Central recently deprecated the Sonatype-style publishing, which means the nexus publishing gradle plugin we used didn't work anymore. As Maven Central has yet to release a replacement plugin for gradle, we simply drop nexus publishing support here and manually upload the archives in the meantime, which is simple enough. We also drop the publishing CI jobs that originally aimed to automate publishing to Maven Central, which we however never came around to use since we didn't want to fully trust Github CI with publishing binaries for us.
.. which we use before manually publishing to Maven Central.
…bindings Cut v0.6.2 bindings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.