chore: pin node via .nvmrc, add the new-provider checklist - #902
Open
ozymandiashh wants to merge 1 commit into
Open
chore: pin node via .nvmrc, add the new-provider checklist#902ozymandiashh wants to merge 1 commit into
ozymandiashh wants to merge 1 commit into
Conversation
.nvmrc matches the engines floor and the appx pin (22.13.0), taming the package-lock churn from contributors on drifting node/npm versions. The checklist distills the house rules new-provider PRs keep relearning: product split, cache-key coupling, reported-cost presence semantics, defensive parsing, probeRoots for doctor, and the real-local-testing bar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small pieces of contributor hygiene:
.nvmrcpinned to 22.13.0 (the engines floor and the appx pin). The dash and root package-lock churn that keeps showing up in diffs comes from contributors on drifting node/npm versions; nvm/fnm users now land on the same version automatically.docs/providers/NEW_PROVIDER.md: the checklist new-provider PRs keep relearning one review at a time - product-split rule with its cache-key coupling rationale, reported-cost presence semantics, defensive parsing, namespaced dedup keys, the seconds-vs-ms timestamp guard, probeRoots for doctor (Cline provider misses every Cline CLI session (~/.cline/data/sessions, cline@3.0.49) — silently reported as $0.00 #874/doctor: extend probeRoots() beyond 7/42 providers to kill the silent-zero class #899), and the real-local-testing bar. Distilled from the feat(cline): read the Cline CLI's sessions layout in the cline provider #891 review cycle; pointing newcomers atcline-cli.tsas the reference implementation.