Skip to content

Fix asset task view#403

Merged
BigRoy merged 3 commits intogetavalon:masterfrom
jasperges:fix-asset-task-view
Jul 30, 2019
Merged

Fix asset task view#403
BigRoy merged 3 commits intogetavalon:masterfrom
jasperges:fix-asset-task-view

Conversation

@jasperges
Copy link
Contributor

As discussed on Gitter this shows only the tasks that were specifically assigned to an asset in the Project Manager.

I also included 2 other (small) things:

  • Make the app import of the Context Manager relative. Now it also import properly in Python 3.7
  • Change the default task icon of the Project Manager to fa.male. This is to make it consistent with Avalon Launcher. If people prefer the folder-o then maybe we should change the Launcher.

If the asset didn't have any tasks set, all tasks from the project
configuration would be shown. This was really confusing and not what
most people expect.
This makes the behaviour more logical and also consistent with Avalon
Launcher.
@@ -1,3 +1,3 @@
from app import show
from .app import show
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, this was not already the case? Surprised this hasn't broken in some way already.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted, and thanks. I'm quite surprised too. But 🥇!

@mottosso mottosso requested a review from BigRoy July 26, 2019 11:42
@mottosso
Copy link
Contributor

Leaving this in your hands Roy

@BigRoy
Copy link
Collaborator

BigRoy commented Jul 26, 2019

Change the default task icon of the Project Manager to fa.male. This is to make it consistent with Avalon Launcher. If people prefer the folder-o then maybe we should change the Launcher.

Never noticed that difference because we have configured icons apparently for all tasks. :D But yes, clever. Looks good too.


Thanks, behavior now makes much more sense again as it's back to the original behavior where it shows no tasks when it has none.

@jasperges
Copy link
Contributor Author

Is this okay to be merged or do more people need to review/approve it first?

@BigRoy
Copy link
Collaborator

BigRoy commented Jul 30, 2019

Let's merge it! Thanks again.

@BigRoy BigRoy merged commit 577e082 into getavalon:master Jul 30, 2019
@jasperges jasperges deleted the fix-asset-task-view branch October 30, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants