This repository was archived by the owner on Oct 10, 2024. It is now read-only.
Closed
Conversation
this change is correcting mapping fps values set like decimals. For example fps set as 25.0 wouldn't be mapped correctly. This change will cast fps to int if it finds its decimal places are zero. It is also adding more fps mapping for maya.
Avoid using `nuke.Text_Knob` since it could be a layout divider if the init value is an empty string.
The spacing between `OptionalAction` menu action icon and label may differ between hosts. Make them all the same.
Fix loader in Houdini 18 as it returns 'long' instead of 'int'
Load options, implementing #346
Doc string added.
Implement Nuke's `lib.read`
change fps mapping in maya
Update `vendor.qargparse`
Fix getavalon#487: Preserve loader styling in Maya 2020
Fix getavalon#485: Allow avalon to initialize correctly with Maya 2020
Because `bpy.context` might not be fully populated when queried from a Qt app, you can use `lib.bpy_context()`. At the moment only `active_object`, `object` and `selected_objects` are added. Other attributes will follow when needed.
Because the `bpy.context` is not always properly populated when queried from within a Qt app, a wrapper is added. Instead of directly using `bpy` you can `from avalon.blender import bpy`. All needed overrides can now be handled there and everything else is simply passed through from the original `bpy`. Hopefully this is a (fairly) short-term remedy and a proper solution will be found in the near future. 8)
sync with upstream
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| if current == "Empty": | ||
| index = 0 | ||
| else: | ||
| for index, member in enumerate(options): |
There was a problem hiding this comment.
Loop control variable 'index' not used within the loop body. If this is intended, start the name with an underscore.
|
|
||
| changed = QtCore.Signal(QtCore.QObject) # A QArgument | ||
|
|
||
| def __init__(self, |
| add_publish_knob, | ||
| maintained_selection, | ||
| read, | ||
|
|
| # QtCore.QCoreApplication instance which does not have | ||
| # the allWidgets method. As such, we call the staticmethod. | ||
| all_widgets = QtWidgets.QApplication.allWidgets() | ||
|
|
| def _uninstall_menu(): | ||
| app = QtWidgets.QApplication.instance() | ||
| widgets = dict((w.objectName(), w) for w in app.allWidgets()) | ||
|
|
|
|
||
| def execute(self, context): | ||
| from .. import style | ||
| self._window = TestApp() |
| """ | ||
|
|
||
| # Check if `self._window` is properly set | ||
| if getattr(self, "_window") is None: |
There was a problem hiding this comment.
Do not call getattr with a constant attribute value, it is not any safer than normal property access.
|
|
||
| try: | ||
| # It says `strtobool` returns a bool, but it returns an int :/ | ||
| return bool(strtobool(os.environ.get('AVALON_DEBUG', "False"))) |
| pipeline.metadata_update(node, imprint_data) | ||
|
|
||
|
|
||
| def lsattr( |
| "ls", | ||
| "publish", | ||
| "containerise", | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to Avalon! Here's how you can get your code merged quickly.
What's changed?
Briefly summarise the changes you've made, something human-readable to get the reader up-to-speed with your thought process (hint: everyone loves bullet-lists). If the PR is in response to an existing issue (it should), link to this here.
Health Check
To ensure your code lives up the standards of Avalon, consult the Pull-Request section of
CONTRIBUTION.mdfor details.Examples
If you are unsure of how to format your pull-request, have a look at these examples. #403, #400