chore(code): silence quiet review-polling ticks - #62
Merged
Conversation
Drop the verbose per-PR 'no new feedback' line from review polling. Quiet ticks now print nothing, even with --verbose; output is actionable-only (new feedback, conflicts, closed PRs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the per-PR
[poll:reviews] <repo>#<n>: no new feedbackverbose line from the review poller. Quiet ticks now print nothing — even with--verbose— so worker logs only surface actionable events (new review feedback, merge conflicts, PRs closing out, errors).Observed in a cron worker log: ~315 identical 'no new feedback' lines per hour (7 watched PRs × tick every 60s) drowning out anything useful.
Changes
packages/code/src/lib/review-polling-acquirer.ts: drop the verbose log inpollPr(), keep the early return; remove the now-unused localverbosedestructure (theverboseoption itself stays for other uses/callers)Testing
review-polling-acquirer+worker-statesuites: 39 pass