feat: add Solana Kit and framework-kit examples (P-2417) - #338
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…le actually uses The tech stack listed Next.js 14, Solana Web3.js and @solana/wallet-adapter-react, none of which the example uses, and linked the removed PR #157 integration. Every line now matches package.json, the top states the example is framework-kit, and the events table names each event's source. Part of P-2417. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015USSsGzRcCswNCNv6eTc8X
16fe7f2 to
3cfcb5d
Compare
|
Follow-up review complete in 3cfcb5d. Cubic found no issues, and I additionally corrected the transaction-source wording: this example's framework-kit React hooks keep transaction state outside client.store, so the demos explicitly call formo.transaction(). The branch is now rebased onto current main, removing the unrelated e2e commit from this PR. |
|
Real-wallet validation uncovered and fixed a separate network mismatch in
Verified with the MetaMask browser wallet: the app dropdown and MetaMask signing prompt now both show Devnet. The example builds against both the locally linked P-2416 SDK and published |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="with-solana/src/components/wallet/NetworkSwitcher.tsx">
<violation number="1" location="with-solana/src/components/wallet/NetworkSwitcher.tsx:28">
P2: When a user changes the select again before the first switch finishes, concurrent handlers can apply selections out of order. A slower earlier handler can overwrite the latest RPC selection or leave the next Wallet Standard session targeting a different cluster; serialize switches or ignore stale requests.</violation>
</file>
<file name="with-solana/src/lib/solana.ts">
<violation number="1" location="with-solana/src/lib/solana.ts:46">
P2: After a network switch, MetaMask reconnects with the cluster captured during module initialization because this spread snapshots the live `defaultChain` getter. Preserve the connector property descriptor or wrap the connector without cloning it so `setWalletStandardCluster` is observed.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
yosriady
changed the title
|
Dependency limit exceeded — report not shown. This pull request scan exceeded the 10,000-dependency limit applied to this scan, so the results are incomplete and may be inaccurate. To avoid reporting false positives, Socket has not posted a report. Upgrade your plan to raise the dependency limit and get complete reports, or view the partial scan in the dashboard. Socket is always free for open source. If this is a non-commercial open source project, contact us to request a free Team account. |
There was a problem hiding this comment.
All reported issues were addressed across 30 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 8 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 34 files (changes from recent commits).
Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 13 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
9842bb4 to
30b41f9
Compare
There was a problem hiding this comment.
All reported issues were addressed across 11 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
1 participant
Addresses P-2417 and validates the SDK change in getformo/sdk#386.
Changes
with-solana-framework-kitas the recommended Solana dapp setup using@solana/client,@solana/react-hooks, andclient.store.with-solanato the lower-level Solana Kit stack:@solana/kit, wallet/RPC plugins, and@solana/react.detect,connect, anddisconnect.Validation
detect,connect, anddisconnecton DevnetThe framework example retains a compatibility cast while CI installs the currently published SDK. After SDK #386 is released, bump the dependency and remove that cast before merging this PR.