docs(components): enable and document the resizable example preview#118
Merged
Conversation
Adds a resize grip to one representative example per page, where narrowing the container produces real reflow: navs-and-tabs, breadcrumb, table, image, carousel, and card. Navbar is deliberately excluded despite being Bootstrap's own showcase for the feature. On Bootstrap 5, navbar-expand-* is a viewport media query, so the grip would squeeze the navbar without ever collapsing it into the toggler. Requires the resize argument added in Hinode v3.1.0.
Add a Resizable preview section to content/components/example.md, in the same Preview/Input style as the show-markup and show-preview sections. Clarifies that the grip demonstrates fluid reflow only and does not trigger Bootstrap's viewport-based responsive breakpoints. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Marks the section with v3.2.0, the release that actually shipped the resize argument. Matches the per-section release badges used elsewhere (e.g. breadcrumb frontmatter).
Contributor
Author
|
🎉 This PR is included in version 1.15.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to gethinode/hinode#2019, which added the
resizeargument to theexampleshortcode. Requires Hinode ≥ v3.2.0.What this does
Documents the feature. Adds a "Resizable preview" section to
components/example.mdtelling readers the corner is draggable — and, crucially, stating what the grip does not do:Without that, the feature over-promises: a reader drags a navbar preview, nothing collapses, and they reasonably conclude the theme is broken.
Enables the grip on six pages, one representative example each:
navs-and-tabs,breadcrumb,table,image,carousel,card.Why those six, and not the others
A component is eligible only if narrowing its container produces real reflow via
flex-wrapor intrinsic sizing. Verified against Bootstrap's own SCSS, then measured in a browser:.navhasflex-wrap: wrap— tabs wrap 1 → 2 → 3 rowsflex-wrap: wrap— wraps 2 → 3 → 4 rows.table-responsivescroller tracks the containerimg-fluidscales 326 → 150 → 100pxRejected, with reasons:
navbar-expand-*compiles to a viewport media query, so the grip squeezes the navbar without ever collapsing it into the toggler. This is Bootstrap's own showcase for the feature, and on Bootstrap 5 it is the single most misleading place we could put a grip.flex-wrap, so they get clipped by theoverflow: hiddenthatresizerequires.invalidateSize()on container resize and would render broken.Both JS-managed risks were checked in a browser: neither the DataTables integration nor the Bootstrap carousel caches its layout, so no JavaScript redraw is needed.
Merge order
Hinode v3.2.0 is released and carries the argument, so this is safe to merge. Note
go.modhas norequireon hinode, so nothing enforces the floor — a site on an older Hinode that bumps mod-docs alone will fail loudly (unsupported argument 'resize', build exits 1) rather than silently. Worth stating the v3.2.0 minimum in the release notes.🤖 Generated with Claude Code