fix(subscriptions): prevent duplicate external_ids per organization#5558
Merged
Conversation
vincent-pochet
approved these changes
May 26, 2026
endenis
force-pushed
the
fix/duplicate-external-ids-on-active-subscriptions
branch
from
June 3, 2026 14:57
7c25a8c to
7965013
Compare
endenis
force-pushed
the
fix/duplicate-external-ids-on-active-subscriptions
branch
from
June 3, 2026 14:59
7965013 to
7690987
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes BIL-44
Context
Multiple active subscriptions with the same
external_idcould coexist within the same organization for different customers.The model validation only ran on
:createmissing status changes (likepending=>active).There was also no database-level unique index.
Description
In this PR:
validate_external_idis now set to run on updates tooSubscriptions::CreateServiceSubscriptionsController. They were by accident creating two active subscriptions and validations now block that