Skip to content

deps: bump radiance for unbounded memory-leak fixes#8912

Merged
myleshorton merged 1 commit into
mainfrom
fisk/bump-radiance-unbounded-leak-fixes
Jul 17, 2026
Merged

deps: bump radiance for unbounded memory-leak fixes#8912
myleshorton merged 1 commit into
mainfrom
fisk/bump-radiance-unbounded-leak-fixes

Conversation

@myleshorton

Copy link
Copy Markdown
Contributor

Why

Ships the unbounded consumer-side memory-leak fixes (getlantern/engineering#3698) to the client. The ticket-180321 repro: an iOS network extension jetsam-killed after the unbounded outbound leaked memory/goroutines/sockets while the client roamed networks.

What

Bumps github.com/getlantern/radiancee6267cf (main), which carries the fix chain down through the module graph:

radiance e6267cf
  → lantern-box v0.0.103        (getlantern/lantern-box#288)
    → broflake f2cacf69         (broflake #371, #372, #373)
  • broflake#371 — engine teardown no longer leaks the bus observer, routers, UI ticker, or a live PeerConnection per connect/disconnect cycle.
  • broflake#372 — context-aware signaling backoff (sleepOrDone); a torn-down outbound exits its retry backoff immediately instead of lingering a full ErrorBackoff (stacked overlapping FSMs during roaming).
  • broflake#373QUICLayer initializes ctx/cancel in its constructor, fixing the Close() data race + lost-cancel leak.

Transitive bumps in this PR: lantern-box v0.0.100 → v0.0.103, broflake c4d1516 → f2cacf69, common (radiance requirement).

Verification

  • go mod tidy run; go.mod + go.sum committed together, with the new broflake/lantern-box h1:+/go.mod hashes present in go.sum — so gomobile bind resolves the new transitive versions consistently (this is where the 2026-04-13 stale-go.sum regression bit us).
  • go build ./lantern-core/... passes (the package tree that wires radiance: mobile bindings, vpn_tunnel, ffi, init).

After merge

unbounded-linode-free is still disabled as the interim mitigation. Once a build from this ships, re-enable it on a canary and soak-test the iOS extension footprint under network roaming to confirm the leak is gone before broad re-enable.

🤖 Generated with Claude Code

Bumps github.com/getlantern/radiance to e6267cf (main), which pulls the
full unbounded consumer-leak fix chain through the module graph:

  radiance e6267cf
    → lantern-box v0.0.103   (getlantern/lantern-box#288)
      → broflake f2cacf69    (getlantern/unbounded#371, #372, #373)

Fixes for getlantern/engineering#3698 (iOS network-extension jetsam kill
from the unbounded outbound leaking memory/goroutines/sockets under
network roaming):
- broflake#371: engine teardown goroutine/PeerConnection leak
- broflake#372: context-aware signaling backoff
- broflake#373: QUICLayer.Close race + lost-cancel leak

Ran go mod tidy; go.mod + go.sum committed together so gomobile bind
resolves the new transitive versions consistently (avoids the
2026-04-13 stale-go.sum regression). lantern-core builds clean.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 17, 2026 21:10
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: cca02198-a162-46b9-8c75-1eb4d1ff55e3

📥 Commits

Reviewing files that changed from the base of the PR and between 3d765cb and 1818e7a.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod
 ___________________________________________
< My mommy says I'm the best code reviewer. >
 -------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fisk/bump-radiance-unbounded-leak-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Go module dependency graph to pull in unbounded consumer-side memory leak fixes by bumping github.com/getlantern/radiance to a newer pseudo-version (commit e6267cfddb00), along with the expected transitive updates (lantern-box, broflake, common).

Changes:

  • Bump direct dependency github.com/getlantern/radiance to v0.0.0-20260717205323-e6267cfddb00.
  • Update indirect dependency versions for broflake, lantern-box, and common as pulled in by the new radiance version.
  • Refresh go.sum entries to match the updated module versions and hashes.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
go.mod Updates radiance and aligns indirect requirements (broflake, lantern-box, common) to the new resolved versions.
go.sum Updates module checksums to match the new dependency graph after the version bumps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@myleshorton
myleshorton merged commit 6d2c05c into main Jul 17, 2026
10 of 11 checks passed
@myleshorton
myleshorton deleted the fisk/bump-radiance-unbounded-leak-fixes branch July 17, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants