Skip to content

deps: bump radiance for the datacap fixes - #8977

Merged
myleshorton merged 1 commit into
mainfrom
fisk/bump-radiance-datacap
Aug 12, 2026
Merged

deps: bump radiance for the datacap fixes#8977
myleshorton merged 1 commit into
mainfrom
fisk/bump-radiance-datacap

Conversation

@myleshorton

@myleshorton myleshorton commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Picks up getlantern/radiance#598 (merged), for a new build.

What it fixes

  • cap_exhausted is terminal — it was being retried; now it stops, and the backoff resets correctly.
  • Slow-poll instead of reconnecting when datacap is disabled (d450614), so a disabled cap no longer drives a reconnect loop.

Derek reported the data cap not working on macOS or Android while working on Windows, in the 9.1.20-beta thread.

Scope

go.mod + go.sum only, one module line each: f0277e466143131f92a74900. go build ./... clean.

Verified the pinned module still carries the iOS jetsam work alongside the new fix:

fix marker present
#596 — only primary host searches at startup if i == 0 in kindling/smart/client.go
#597 — monitor starts before libbox bring-up SetExecutor in vpn/memmon.go
#598 — datacap cap_exhausted in account/datacap.go

Verification note

The iOS memory behaviour was device-verified at the previous pin (f0277e4): peak 37.94 MB, plateau 32.77 MB, no jetsam, clean teardown — see #8975. This bump touches account/ only, so that result should carry, but it has not been re-run on device. Happy to do a connect test before the build if wanted.

🤖 Generated with Claude Code

https://claude.ai/code/session_01SkKS8hGeHM5g4BDPvxcamg

Summary by CodeRabbit

  • Chores
    • Updated an internal dependency to a newer version.
    • No user-facing functionality or behavior changes.

Picks up getlantern/radiance#598:

- cap_exhausted is treated as terminal rather than retried, and the backoff
  resets correctly.
- The datacap stream slow-polls instead of reconnecting when datacap is
  disabled, so a disabled cap no longer drives a reconnect loop.

Derek reported the data cap not working on macOS or Android while working on
Windows (9.1.20-beta thread).

Carries forward the iOS jetsam fixes already pinned: #596 (only the primary
config host searches at startup) and #597 (memory monitor starts before libbox
bring-up).
Copilot AI lite review requested due to automatic review settings August 12, 2026 22:38
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f36a8f18-fe2c-4325-89a0-82db7c357d24

📥 Commits

Reviewing files that changed from the base of the PR and between cd9e202 and bdf104a.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

📝 Walkthrough

Walkthrough

The pull request updates the github.com/getlantern/radiance dependency in go.mod from one pseudo-version to a newer pseudo-version.

Changes

Radiance dependency update

Layer / File(s) Summary
Update Radiance module version
go.mod
The required github.com/getlantern/radiance dependency now uses pseudo-version v0.0.0-20260812223628-131f92a74900.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Mergeability Score: ⚪ Minimal · up to bdf10

This dependency-only update does not introduce an actionable merge-blocking risk; it is merge-ready after normal checks and review.

Possibly related PRs

Suggested reviewers: jigar-f, garmr-ulfr

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the radiance dependency update and its purpose of including datacap fixes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fisk/bump-radiance-datacap

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the github.com/getlantern/radiance dependency to pick up the recently merged datacap fixes (radiance PR #598), aligning Lantern’s embedded Radiance backend with corrected cap_exhausted handling and improved polling behavior when datacap is disabled.

Changes:

  • Update go.mod to require github.com/getlantern/radiance at v0.0.0-20260812223628-131f92a74900.
  • Update go.sum entries to match the new Radiance pseudo-version and checksums.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
go.mod Bumps the Radiance module pseudo-version to include datacap fixes.
go.sum Updates sum entries for the bumped Radiance version.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@myleshorton
myleshorton merged commit 16fb500 into main Aug 12, 2026
11 checks passed
@myleshorton
myleshorton deleted the fisk/bump-radiance-datacap branch August 12, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants