Skip to content

Update to latest kindling/fronted that drops unnecessary dependency o… - #362

Merged
myleshorton merged 1 commit into
mainfrom
myles/kindling-no-tlsdialer
Mar 20, 2026
Merged

Update to latest kindling/fronted that drops unnecessary dependency o…#362
myleshorton merged 1 commit into
mainfrom
myles/kindling-no-tlsdialer

Conversation

@myleshorton

Copy link
Copy Markdown
Contributor

This pull request updates the go.mod dependencies by upgrading some packages to newer versions and removing several indirect dependencies that are no longer needed. These changes help keep the project up-to-date and reduce unnecessary dependencies.

Dependency upgrades:

  • Upgraded github.com/getlantern/fronted and github.com/getlantern/kindling to newer versions to include the latest features and bug fixes.

Dependency removals (cleanup):

  • Removed several unused or obsolete indirect dependencies, including github.com/getlantern/golog, github.com/getlantern/tlsdialer/v3, github.com/getlantern/fdcount, github.com/getlantern/hex, github.com/getlantern/iptool, github.com/getlantern/mtime, github.com/getlantern/netx, github.com/go-stack/stack, and github.com/oxtoacart/bpool, which helps reduce the project’s footprint and potential security surface. [1] [2] [3] [4]…n tlsdialer

Copilot AI review requested due to automatic review settings March 19, 2026 22:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Go module dependencies by bumping github.com/getlantern/fronted and github.com/getlantern/kindling, and tidying go.mod to remove a set of now-unlisted indirect requirements.

Changes:

  • Upgraded github.com/getlantern/fronted to v0.0.0-20260319225233-cf2160f85053.
  • Upgraded github.com/getlantern/kindling to v0.0.0-20260319225424-4736208dd171.
  • Removed several indirect require entries from go.mod and updated go.sum accordingly.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 4 comments.

File Description
go.mod Bumps fronted/kindling and removes multiple indirect require entries.
go.sum Updates checksums to match the new module graph after the version bumps and tidy.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread go.mod
Comment on lines 241 to 244
github.com/go-logr/logr v1.4.3 // indirect
github.com/go-logr/stdr v1.2.2 // indirect
github.com/go-ole/go-ole v1.3.0 // indirect
github.com/go-stack/stack v1.8.1 // indirect
github.com/gobwas/httphead v0.1.0 // indirect

Copilot AI Mar 19, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github.com/go-stack/stack was removed from go.mod, but it still exists in go.sum, which indicates it’s still being pulled in transitively. If the intent is to fully drop this dependency (as implied by the PR description), please confirm it’s no longer needed or adjust the description to clarify the scope of removal.

Copilot uses AI. Check for mistakes.
Comment thread go.mod
Comment on lines 259 to 261
github.com/metacubex/tfo-go v0.0.0-20250921095601-b102db4216c0 // indirect
github.com/miekg/dns v1.1.67
github.com/oxtoacart/bpool v0.0.0-20190530202638-03653db5a59c // indirect
github.com/pierrec/lz4/v4 v4.1.22 // indirect

Copilot AI Mar 19, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github.com/oxtoacart/bpool was removed from go.mod, but go.sum still contains it, so it hasn’t been fully removed from the resolved dependency set. If the goal is dependency footprint reduction, please identify what still depends on it (or update the PR description to note it’s only removed as an explicit indirect requirement).

Copilot uses AI. Check for mistakes.
Comment thread go.mod
Comment on lines 115 to 117
github.com/getlantern/errors v1.0.4 // indirect
github.com/getlantern/golog v0.0.0-20230503153817-8e72de7e0a65 // indirect
github.com/getlantern/lantern-water v0.0.0-20260313142412-dfc64287c8c8 // indirect
github.com/getlantern/samizdat v0.0.3-0.20260310125445-325cf1bd1b60 // indirect

Copilot AI Mar 19, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github.com/getlantern/golog was removed from go.mod, but it still appears in go.sum, meaning it’s still being pulled in transitively (or via dependency tests). If the intent is to remove it from the project’s dependency graph, please investigate why it’s still required; otherwise, consider adjusting the PR description to clarify that it’s only removed as an explicit go.mod requirement.

Copilot uses AI. Check for mistakes.
Comment thread go.mod
Comment on lines 234 to 236
github.com/getlantern/context v0.0.0-20220418194847-3d5e7a086201 // indirect
github.com/getlantern/fdcount v0.0.0-20210503151800-5decd65b3731 // indirect
github.com/getlantern/hex v0.0.0-20220104173244-ad7e4b9194dc // indirect
github.com/getlantern/hidden v0.0.0-20220104173330-f221c5a24770 // indirect
github.com/getlantern/iptool v0.0.0-20230112135223-c00e863b2696 // indirect
github.com/getlantern/mtime v0.0.0-20200417132445-23682092d1f7 // indirect
github.com/getlantern/netx v0.0.0-20240830183145-c257516187f0 // indirect
github.com/getlantern/ops v0.0.0-20231025133620-f368ab734534 // indirect

Copilot AI Mar 19, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github.com/getlantern/hex was removed from go.mod, but it still appears in go.sum, so it’s still part of the resolved module set. If the goal is to eliminate this dependency entirely (per the PR description’s “cleanup”), please track down which dependency still requires it; otherwise, update the PR description to reflect that it’s no longer an explicit indirect requirement but still transitive.

Copilot uses AI. Check for mistakes.
@myleshorton
myleshorton merged commit fcb0501 into main Mar 20, 2026
6 checks passed
@myleshorton
myleshorton deleted the myles/kindling-no-tlsdialer branch March 20, 2026 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants