Skip to content
This repository was archived by the owner on May 5, 2021. It is now read-only.

Add logback config#13

Merged
yanokwa merged 1 commit intogetodk:masterfrom
yanokwa:logback
Jun 4, 2020
Merged

Add logback config#13
yanokwa merged 1 commit intogetodk:masterfrom
yanokwa:logback

Conversation

@yanokwa
Copy link
Copy Markdown
Member

@yanokwa yanokwa commented Jun 4, 2020

Tested by running on ./aggregate-cli -i -f -y -c /root/aggregate-config.json on https://test.aggregate.getodk.org.

  • Confirmed that upgrade was successful
  • Confirmed that no debug information was printed out
  • Confirmed that output was printed to screen but not the log file (is this expected behavior, @ggalmazor?)

Once this is reviewed and merge, I can do a release.

@yanokwa yanokwa requested review from ggalmazor and lognaturel June 4, 2020 20:20
Copy link
Copy Markdown
Member

@lognaturel lognaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior looks expected to me. There would only be a file created if you hit info-level logging from the tool itself and you probably didn't.

@yanokwa yanokwa merged commit 620508c into getodk:master Jun 4, 2020
@ggalmazor
Copy link
Copy Markdown
Contributor

Confirmed that output was printed to screen but not the log file (is this expected behavior, @ggalmazor?)

Yes, that'd be correct. The intention was to use standard output/error for user feedback. Errors and other tracing info should go to the logs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants