Merged
Conversation
lognaturel
reviewed
Jul 29, 2020
Contributor
Author
|
nope i did that wrong
… On Jul 29, 2020, at 14:22, Hélène Martin ***@***.***> wrote:
@lognaturel commented on this pull request.
In files/nginx/odk.conf.template:
> @@ -21,7 +21,7 @@ server {
gzip_http_version 1.1;
gzip_types text/plain text/css application/json application/x-javascript text/xml text/csv;
- location /enketo {
+ location /_ {
proxy_pass http://enketo:8005/enketo;
I'm surprised to see everything else change to _ but this proxy_pass stay the same. Wouldn't the Enketo base path have to remain enketo for this to work? (This is not super familiar to me and I think you've tried it so I'm probably misunderstanding.)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
* shorter, removes noncritical detail. * depends on a corresponding frontend pr.
issa-tseng
force-pushed
the
issa/enketo-to-_
branch
from
e31ab9c to
42ac9b9
Compare
lognaturel
approved these changes
Aug 1, 2020
apparently some SMS clients turn _ into spaces.
issa-tseng
changed the title
* most importantly adding the query parameter we need to auth public links. * but also adding some other recommended settings.
issa-tseng
changed the title
Closed
lognaturel
approved these changes
Aug 14, 2020
Member
|
We’ll need another update once Enketo gets a new patch. |
lognaturel
approved these changes
Aug 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.