ci/close-issues: support more issue ref notations #1599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latin-panda
approved these changes
Jan 30, 2026
| const body = context.payload.pull_request.body || ""; | ||
| const closedIssues = new Set(); | ||
| const issueRegex = /(Closes|Fixes|Resolves)\s*:?\s+#(\d+)/gi; | ||
| const issueRegex = /(Closes|Fixes|Resolves)\s*:?\s+(?:(?:https:\/\/)?github.com\/getodk\/central\/issues\/|getodk\/central#|#)(\d+)/gi; |
Contributor
There was a problem hiding this comment.
Optional:
It could support variants of the same words, e.g., Close, Closes, Closed
Suggested change
| const issueRegex = /(Closes|Fixes|Resolves)\s*:?\s+(?:(?:https:\/\/)?github.com\/getodk\/central\/issues\/|getodk\/central#|#)(\d+)/gi; | |
| const issueRegex = /((?:close|fix|resolve)(?:s|d|es|ed)?)\s*:?\s+(?:(?:https:\/\/)?github.com\/getodk\/central\/issues\/|getodk\/central#|#)(\d+)/gi; |
Contributor
Author
There was a problem hiding this comment.
Good idea, I'll follow up 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1592
What has been done to verify that this works as intended?
masterin the fork, and tested with various new issues and different structures of commit message. REVIEW: is this necessary?Why is this the best possible solution? Were any other approaches considered?
Another approach would be to extract the JS of the
scriptsection ofclose-issues.ymlinto a.jsfile, and write more traditional tests. However, this would be a much more significant change to the overhead of the workflow, asactions/checkoutwould have to be added, and NodeJS would need to be installed.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
No effect.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
nextbranch OR only changed documentation/infrastructure (masteris stable and used in production)