Skip to content

nginx/csp: tighten favicon allowance for blank.html#1855

Merged
alxndrsn merged 5 commits into
getodk:nextfrom
alxndrsn:tighter-favicon-blank
Apr 30, 2026
Merged

nginx/csp: tighten favicon allowance for blank.html#1855
alxndrsn merged 5 commits into
getodk:nextfrom
alxndrsn:tighter-favicon-blank

Conversation

@alxndrsn
Copy link
Copy Markdown
Contributor

@alxndrsn alxndrsn commented Apr 28, 2026

In line with #1854

What has been done to verify that this works as intended?

  • updated tests
  • tested on dev

Why is this the best possible solution? Were any other approaches considered?

More precise than previous.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Basically invisible.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • branched off and targeted the next branch OR only changed documentation/infrastructure (master is stable and used in production)
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@alxndrsn alxndrsn marked this pull request as ready for review April 28, 2026 11:20
Comment thread test/nginx/src/mocha/nginx.spec.js Outdated
@alxndrsn alxndrsn merged commit 711c6ad into getodk:next Apr 30, 2026
6 checks passed
@alxndrsn alxndrsn deleted the tighter-favicon-blank branch April 30, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants