Skip to content

nginx/csp: blank.html: allow form-action 'self'#1857

Merged
alxndrsn merged 1 commit into
getodk:nextfrom
alxndrsn:blank-form-action
Apr 29, 2026
Merged

nginx/csp: blank.html: allow form-action 'self'#1857
alxndrsn merged 1 commit into
getodk:nextfrom
alxndrsn:blank-form-action

Conversation

@alxndrsn
Copy link
Copy Markdown
Contributor

@alxndrsn alxndrsn commented Apr 28, 2026

Closes #1856

What has been done to verify that this works as intended?

Updated tests.

Why is this the best possible solution? Were any other approaches considered?

Violations were reported to Sentry. An alternative would be to make the decrypt downloading in central-frontend less arcane. But that's not likely to be on the cards.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Should prevent incorrect reports.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • branched off and targeted the next branch OR only changed documentation/infrastructure (master is stable and used in production)
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@alxndrsn alxndrsn changed the base branch from master to next April 28, 2026 11:35
@alxndrsn alxndrsn changed the title Blank form action nginx/csp: blank.html: allow form-action 'self' Apr 28, 2026
@alxndrsn alxndrsn marked this pull request as ready for review April 28, 2026 11:47
@matthew-white
Copy link
Copy Markdown
Member

An alternative would be to make the decrypt downloading in central-frontend less arcane. But that's not likely to be on the cards.

I'm certainly open to it! It doesn't strike me as a priority, but I definitely agree that it's arcane.

@matthew-white matthew-white linked an issue Apr 29, 2026 that may be closed by this pull request
@alxndrsn alxndrsn merged commit 1431cb1 into getodk:next Apr 29, 2026
6 checks passed
@alxndrsn alxndrsn deleted the blank-form-action branch April 29, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allow form-action: 'self' for blank.html

2 participants