Skip to content

nginx: fix escaping in /fonts/ matcher#1863

Merged
alxndrsn merged 3 commits into
getodk:nextfrom
alxndrsn:fix-font-match
May 7, 2026
Merged

nginx: fix escaping in /fonts/ matcher#1863
alxndrsn merged 3 commits into
getodk:nextfrom
alxndrsn:fix-font-match

Conversation

@alxndrsn
Copy link
Copy Markdown
Contributor

@alxndrsn alxndrsn commented May 1, 2026

Noted while working on #1810

What has been done to verify that this works as intended?

The question mark is intended as a literal ? rather than making the .* optional.

Why is this the best possible solution? Were any other approaches considered?

Seems like a simple change.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

No likely effect - such a minor detail, expected URLs would have matched anyway.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • branched off and targeted the next branch OR only changed documentation/infrastructure (master is stable and used in production)
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

Comment thread files/nginx/odk.conf.template Outdated
@alxndrsn alxndrsn marked this pull request as ready for review May 6, 2026 12:57
@alxndrsn alxndrsn merged commit 625eb98 into getodk:next May 7, 2026
6 checks passed
@alxndrsn alxndrsn deleted the fix-font-match branch May 7, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants