Resolved error that caused FormEntryActivity to go to the FormChooser List#2234
Merged
Merged
Conversation
…List instead of the MainMenuActivity Added finish to onItemClicked listener code that triggers the FormEntryActivity to be opened. This was accidentally removed when the FormChooserList was being refactored to support storage permissions. The denied function of the listener is utilizing a method called finishActivities to clear the entire stack instead of finish to just do so for the current activity, so while removing the finish method this was one was removed as well.
grzesiek2010
approved these changes
May 23, 2018
Member
|
@opendatakit-bot label "needs testing" |
Contributor
|
Tested with success! Verified on Android 4.1, 4.2, 4.4, 5.1, 6.0, 7.0, 8.1 Verified cases:
@opendatakit-bot label "behavior verified" |
lognaturel
approved these changes
May 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
finishtoOnItemClickedlistener code that triggers the FormEntryActivity to be opened. This was accidentally removed when theFormChooserListwas being refactored to support storage permissions. The denied function of the permissions listener is utilizing a method calledfinishActivitiesto clear the entire stack instead of finish to just do so for the current activity, so while removing the finish method this was one was removed as well and the FormChooserList was still on the activity stack so when the FormEntryActivity was finished after saving it would navigate back to it.Closes #2229
What has been done to verify that this works as intended?
I opened a form and once I saved it or ignored the changes the app navigates back to the main screen.
Why is this the best possible solution? Were any other approaches considered?
Are there any risks to merging this code? If so, what are they?
No.
Do we need any specific form for testing your changes? If so, please attach one.
Any form works.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Before submitting this PR, please make sure you have:
./gradlew pmd checkstyle lint findbugsand confirmed all checks still pass.