Skip to content

Fix handling validation results#7186

Open
grzesiek2010 wants to merge 2 commits intogetodk:masterfrom
grzesiek2010:COLLECT-7183
Open

Fix handling validation results#7186
grzesiek2010 wants to merge 2 commits intogetodk:masterfrom
grzesiek2010:COLLECT-7183

Conversation

@grzesiek2010
Copy link
Copy Markdown
Member

@grzesiek2010 grzesiek2010 commented Apr 16, 2026

Closes #7183

Why is this the best possible solution? Were any other approaches considered?

Handling validation results was broken because it first checked whether the current view was an ODK view before attempting to display the result. However, at the end of the form, the view is no longer an ODK view.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Here, the risk is limited to handling validation results within a form, so please verify that there is no regression. That should be sufficient.

Do we need any specific form for testing your changes? If so, please attach one.

Any form.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 marked this pull request as ready for review April 16, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The toast "Success! No errors found in your form." doesn't appear in the end page of a form

1 participant