Fix updating Snackbar position#7204
Open
grzesiek2010 wants to merge 2 commits intogetodk:masterfrom
Open
Conversation
Member
Author
|
@dbemke as you’ve already noticed, it’s not easy to handle the positioning of Snackbars correctly, so I’m marking this PR as needs testing early to see if the solution seems promising. Please take a look when you have some time. |
Everything seems to work well. |
|
Tested with Success! Verified on device with Android 10, 8.1 Verified cases:
|
|
Tested with success Verified on phone with Android 10,16 and tablet with android 16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7197
Closes #7201
Why is this the best possible solution? Were any other approaches considered?
The issue was related to displaying snackbars above an anchor view. Previously, we set the anchor view in
SnackbarUtilswhen creating a snackbar, and then adjusted its position separately to support edge-to-edge layouts. These two approaches conflicted with each other. I removed the anchor view assignment fromSnackbarUtilsand improved the position calculation so that it now accounts not only for system bars and the keyboard, but also for a provided anchor view.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This should fix the snackbar position across different states/cases. Please test various snackbars to ensure everything works correctly.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest