Skip to content

Fix updating Snackbar position#7204

Open
grzesiek2010 wants to merge 2 commits intogetodk:masterfrom
grzesiek2010:COLLECT-7197
Open

Fix updating Snackbar position#7204
grzesiek2010 wants to merge 2 commits intogetodk:masterfrom
grzesiek2010:COLLECT-7197

Conversation

@grzesiek2010
Copy link
Copy Markdown
Member

@grzesiek2010 grzesiek2010 commented Apr 24, 2026

Closes #7197
Closes #7201

Why is this the best possible solution? Were any other approaches considered?

The issue was related to displaying snackbars above an anchor view. Previously, we set the anchor view in SnackbarUtils when creating a snackbar, and then adjusted its position separately to support edge-to-edge layouts. These two approaches conflicted with each other. I removed the anchor view assignment from SnackbarUtils and improved the position calculation so that it now accounts not only for system bars and the keyboard, but also for a provided anchor view.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

This should fix the snackbar position across different states/cases. Please test various snackbars to ensure everything works correctly.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010
Copy link
Copy Markdown
Member Author

@dbemke as you’ve already noticed, it’s not easy to handle the positioning of Snackbars correctly, so I’m marking this PR as needs testing early to see if the solution seems promising. Please take a look when you have some time.

@dbemke
Copy link
Copy Markdown

dbemke commented Apr 29, 2026

@dbemke as you’ve already noticed, it’s not easy to handle the positioning of Snackbars correctly, so I’m marking this PR as needs testing early to see if the solution seems promising. Please take a look when you have some time.

Everything seems to work well.

@dbemke
Copy link
Copy Markdown

dbemke commented Apr 30, 2026

Tested with Success!

Verified on device with Android 10, 8.1

Verified cases:

@WKobus
Copy link
Copy Markdown

WKobus commented Apr 30, 2026

Tested with success

Verified on phone with Android 10,16 and tablet with android 16

@grzesiek2010 grzesiek2010 marked this pull request as ready for review April 30, 2026 12:42
@grzesiek2010 grzesiek2010 requested a review from seadowg April 30, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants