Skip to content

Stop blocking the addition of new points when constraint fails#7213

Merged
grzesiek2010 merged 2 commits intogetodk:v2026.2.xfrom
grzesiek2010:COLLECT-7191
Apr 30, 2026
Merged

Stop blocking the addition of new points when constraint fails#7213
grzesiek2010 merged 2 commits intogetodk:v2026.2.xfrom
grzesiek2010:COLLECT-7191

Conversation

@grzesiek2010
Copy link
Copy Markdown
Member

@grzesiek2010 grzesiek2010 commented Apr 29, 2026

Closes #7191

Why is this the best possible solution? Were any other approaches considered?

The decision to unblock adding new points is a result of our internal discussions. There is nothing worth discussing regarding implementation changes.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

We should not block adding new points when a geoshape/trace is invalid. We should still display errors and highlight the geotrace/geoshape in red, and block saving, but allow the user to fix the issue by adding new points.
There is no need to test every map engine, we can focus on one.

Do we need any specific form for testing your changes? If so, please attach one.

I used: geo.xlsx

Does this change require updates to documentation? If so, please file an issue here and include the link below.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 marked this pull request as ready for review April 29, 2026 11:00
@grzesiek2010 grzesiek2010 requested a review from seadowg April 29, 2026 11:00
@seadowg seadowg added needs testing high priority Should be looked at before other PRs/issues labels Apr 29, 2026
@WKobus
Copy link
Copy Markdown

WKobus commented Apr 30, 2026

Tested with success

Verified on Android 16

Verified cases:

  • Adding, moving and removing points in forms with intersects and incremental
  • Regression checks on geo widgets
  • Horizontal and portrait view
  • Different map sources

@dbemke
Copy link
Copy Markdown

dbemke commented Apr 30, 2026

Tested with success

Verified on Android 10

@grzesiek2010 grzesiek2010 merged commit 683e83e into getodk:v2026.2.x Apr 30, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

behavior verified high priority Should be looked at before other PRs/issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants