Stop blocking the addition of new points when constraint fails#7213
Merged
grzesiek2010 merged 2 commits intogetodk:v2026.2.xfrom Apr 30, 2026
Merged
Stop blocking the addition of new points when constraint fails#7213grzesiek2010 merged 2 commits intogetodk:v2026.2.xfrom
grzesiek2010 merged 2 commits intogetodk:v2026.2.xfrom
Conversation
seadowg
approved these changes
Apr 29, 2026
|
Tested with success Verified on Android 16 Verified cases:
|
|
Tested with success Verified on Android 10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7191
Why is this the best possible solution? Were any other approaches considered?
The decision to unblock adding new points is a result of our internal discussions. There is nothing worth discussing regarding implementation changes.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
We should not block adding new points when a geoshape/trace is invalid. We should still display errors and highlight the geotrace/geoshape in red, and block saving, but allow the user to fix the issue by adding new points.
There is no need to test every map engine, we can focus on one.
Do we need any specific form for testing your changes? If so, please attach one.
I used: geo.xlsx
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest