chore: update lint, gh actions, turbo#736
Conversation
|
|
|
||
| steps: | ||
| - uses: 'actions/checkout@v4' | ||
| - uses: 'actions/checkout@v5' |
There was a problem hiding this comment.
GH is deprecating Node 20 so we're getting warnings on our builds. Updating these resolved all but one (volta-cli).
| timezoneLinux: ${{ env.TZ }} | ||
| timezoneMacos: ${{ env.TZ }} | ||
| timezoneWindows: ${{ env.TZ }} | ||
|
|
There was a problem hiding this comment.
This action looks to be in maintenance mode. People have forked it but because the build only runs on linux it's overkill. Turns out we don't need to set the tz anyway, but if tests start breaking we can just set the tz ourselves.
| interface Assertion<T = any> extends DeriveStaticVitestExpectExtension<AppearanceExtensions, T> {} | ||
| interface AsymmetricMatchersContaining | ||
| extends DeriveStaticVitestExpectExtension<AppearanceExtensions> {} | ||
| interface AsymmetricMatchersContaining extends DeriveStaticVitestExpectExtension<AppearanceExtensions> {} |
There was a problem hiding this comment.
There are a bunch of formatting changes like this which is (I think) just because of a prettier bump. I think the changes are equivalent, and just accepting them means we stay on the recommended. Let me know if you prefer the old style.
| import vue3Essential from 'eslint-plugin-vue/lib/configs/vue3-essential.js'; | ||
| import vue3Recommended from 'eslint-plugin-vue/lib/configs/vue3-recommended.js'; | ||
| import vue3StronglyRecommended from 'eslint-plugin-vue/lib/configs/vue3-strongly-recommended.js'; | ||
| import vueProcessor from 'eslint-plugin-vue/lib/processor.js'; |
There was a problem hiding this comment.
Imported inline below.
| */ | ||
|
|
||
| export default tseslint.config( | ||
| export default defineConfig( |
There was a problem hiding this comment.
The old way has been deprecated for some time.
latin-panda
left a comment
latin-panda
left a comment
There was a problem hiding this comment.
Looks great! Thanks
2 participants
My main focuses this round were (a) ticking off more dependabot security warnings, and (b) resolving build warnings.