Skip to content

fix(#799): flips min and max labels to match the selected value #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garethbowen merged 1 commit into from
May 7, 2026
Merged

fix(#799): flips min and max labels to match the selected value #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/chilly-mice-admire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@getodk/web-forms': patch
---

Fixed vertical range control to record the correct value
10 changes: 5 additions & 5 deletions packages/web-forms/src/components/form-elements/range/RangeControl.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,6 @@ const orientation = props.node.appearances.vertical ? 'vertical' : 'horizontal';
<div class="range-value">
<span>{{ numberValue }}</span>
</div>
<div class="range-bound range-min">
{{ start }}
</div>
<RangeSlider
:id="node.nodeId"
:disabled="node.currentState.readonly"
Expand All @@ -72,6 +69,9 @@ const orientation = props.node.appearances.vertical ? 'vertical' : 'horizontal';
:model-value="numberValue"
@update:model-value="setValue"
/>
<div class="range-bound range-min">
{{ start }}
</div>
Copy link
Copy Markdown
Collaborator Author

@garethbowen garethbowen May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This move wasn't strictly necessary but it feels more logical for both vertical and horizontal to have the min and max labels beside each other.

<div class="range-bound range-max">
{{ end }}
</div>
Expand Down Expand Up @@ -164,11 +164,11 @@ const orientation = props.node.appearances.vertical ? 'vertical' : 'horizontal';
}

.range-min {
top: 0;
bottom: 0;
}

.range-max {
bottom: 0;
top: 0;
}

.range-value {
Expand Down