Skip to content

fix: add test IDs to Import Video and Load Project buttons#151

Open
Dodothereal wants to merge 1 commit into
getopenscreen:mainfrom
Dodothereal:fix/130-windows-native-checklist-spec-ts-referen
Open

fix: add test IDs to Import Video and Load Project buttons#151
Dodothereal wants to merge 1 commit into
getopenscreen:mainfrom
Dodothereal:fix/130-windows-native-checklist-spec-ts-referen

Conversation

@Dodothereal

@Dodothereal Dodothereal commented Jul 24, 2026

Copy link
Copy Markdown

fix: add test IDs to Import Video and Load Project buttons

Summary

Add data-testid attributes to Import Video File and Load Project buttons in EditorEmptyState to fix e2e test selectors.

Fixes #130

Changes

  • Added data-testid="launch-open-video-button" to the Import Video File button
  • Added data-testid="launch-open-project-button" to the Load Project button

Testing

Verified the attributes are present in the rendered component; ran type checking and linting via sandbox (no errors). The changes are minimal and do not affect functionality.


AI assistance disclosure

This contribution was produced by an autonomous AI coding agent (Claude Code) that @Dodothereal operates and monitors. @Dodothereal is accountable for it, will address review feedback promptly, and will close this PR immediately if this kind of contribution is unwelcome in this project. Commits carry an Assisted-by: Claude Code trailer.

Summary by CodeRabbit

  • Tests
    • Added test identifiers to the “Import video” and “Load project” buttons for more reliable automated testing.

…tate

Fixes getopenscreen#130 by adding data-testid attributes to the buttons referenced in
windows-native-checklist.spec.ts.

Assisted-by: Claude Code
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c9f1ce57-451c-40dd-8c55-f773adafab40

📥 Commits

Reviewing files that changed from the base of the PR and between f508a21 and 7af9401.

📒 Files selected for processing (1)
  • src/components/video-editor/EditorEmptyState.tsx

📝 Walkthrough

Walkthrough

Adds data-testid attributes to the video import and project load buttons in the editor empty state.

Changes

Editor empty-state test identifiers

Layer / File(s) Summary
Annotate empty-state actions
src/components/video-editor/EditorEmptyState.tsx
Adds launch-open-video-button and launch-open-project-button test identifiers to the corresponding buttons.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: etiennelescot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding test IDs to the Import Video and Load Project buttons.
Description check ✅ Passed The description covers the summary, related issue, changes, and testing, with only optional template sections omitted.
Linked Issues check ✅ Passed The change adds the missing selectors required by issue #130 for the two buttons referenced in the Windows checklist tests.
Out of Scope Changes check ✅ Passed No unrelated or extra scope changes are present; the PR only adds the two requested data-testid attributes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

windows-native-checklist.spec.ts references testids that don't exist (launch-open-video-button, launch-open-project-button)

1 participant