Skip to content

fix: avoid AV1 clip-switch crashes on Windows #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
My-Denia wants to merge 4 commits into
base: main
Choose a base branch
from
+815 −71
Open

fix: avoid AV1 clip-switch crashes on Windows #602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17695db
fix: avoid AV1 clip-switch crashes on Windows
My-Denia Sep 4, 2026
92a6655
fix: preserve Windows AV1 software decode timing
My-Denia Sep 4, 2026
5b48c91
docs: record the 554 pre-fix and post-fix crash A/B
My-Denia Sep 4, 2026
cebfc2f
docs: name the issue number in the A/B verdict cell
My-Denia Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions crates/compositor/src/cpu_frames_windows.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,11 @@ impl CpuFrames {
}

self.upload(w, h)?;
// `Decoder::seek_to` and `decode_forward_to` inspect the presentation frame returned by
// `present`, so it must carry the decoded frame's timing just like the macOS/Linux CPU
// paths. Leaving the allocation defaults here makes every non-H.264 frame look untimed.
(*self.present).pts = (*src).pts;
(*self.present).best_effort_timestamp = (*src).best_effort_timestamp;
Ok(self.present)
}

Expand Down
Loading
Loading