Give workflow persistence a dedicated repository - #33
Open
boudra wants to merge 1 commit into
Open
Conversation
Keep durable workflow SQL, row mapping, and transaction recovery behind one repository while preserving the existing Database contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL workflow persistence now has a dedicated repository, so workflow changes no longer require navigating the broad
PgDatabaseimplementation. The existingDatabasecontract and runtime behavior remain unchanged.Goals
PgDatabase.Non-goals
Why
src/db/pg.tshad grown to nearly 5,000 lines, with durable workflow persistence occupying its largest coherent responsibility cluster. Existing connection and provider-event repositories already establish a repository boundary for PostgreSQL domains; this applies the same ownership model to workflows while leaving the stableDatabaseinterface intact.Verification
npm test— 643 passed, 14 skippednpm run typechecknpm run lint:nodenpm run format:checknpm run db:checkRisk surface
The meaningful risk is transaction behavior at the workflow/agent-execution boundary: atomic execution creation and usage reservation, deadline recovery, terminal notification leasing, and idle-deadline synchronization. The PostgreSQL workflow integration suite and full test suite cover these paths. There are no schema or externally observable changes.
Follow-up candidates