fix(workflows): builtin workflows use real tier names (economy/standard, not low/medium) (#47) - #48
Merged
Merged
Conversation
…rd, not low/medium) (#47) The 5 builtin workflows used tier:'low'/'medium' which DON'T EXIST in BUILTIN_TIERS (economy/standard/frontier) — so resolveAgentModel returned 'tier not found', every agent() call failed (returned null), and the builtins completed-with-nulls (did nothing). Discovered by a read-only review subagent verifying the PR #46 workflow-API docs against the source. Renames in src/workflows/builtin/*.js: - tier:'low' -> tier:'economy' (cheapest — minimax) - tier:'medium' -> tier:'standard' (mid — glm->minimax) - tier:'high' -> tier:'frontier' (not used by builtins; renamed for completeness) Guard test (+3): every builtin's tier names resolve against BUILTIN_TIERS; the old low/medium/high names must not reappear; BUILTIN_TIERS defines economy/standard/frontier. 646/646 tests, typecheck clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #47: the 5 builtin workflows used
tier: 'low'/'medium'which don't exist inBUILTIN_TIERS(economy/standard/frontier) →resolveAgentModelreturnedtier not found→ everyagent()call failed (returnednull) → the builtins completed-with-nulls (did nothing). Discovered by a read-only review subagent verifying the PR #46 workflow-API docs against the source.Change
Renames in
src/workflows/builtin/*.js:tier: 'low'→tier: 'economy'(cheapest — minimax)tier: 'medium'→tier: 'standard'(mid — glm→minimax)tier: 'high'→tier: 'frontier'(not used by builtins; renamed for completeness)Guard test (+3)
test/workflow-builtin-tiers.test.mts:tier: 'X'names resolve againstBUILTIN_TIERS(catches a non-existent tier);low/medium/highnames must not reappear (regression guard);BUILTIN_TIERSdefineseconomy/standard/frontier.Verification
pnpm typecheckclean;pnpm test:run646/646 (+3 new).tier not found). The "produces non-null agent results" acceptance is verified by the next release-gate smoke (a real workflow run — the dispatch producing text is a real-pi check, not a unit test).Closes #47.