fix(images): update digest field for a mapped image#1308
Merged
carolynvs merged 2 commits intogetporter:mainfrom Oct 20, 2020
Merged
fix(images): update digest field for a mapped image#1308carolynvs merged 2 commits intogetporter:mainfrom
carolynvs merged 2 commits intogetporter:mainfrom
Conversation
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
carolynvs
requested changes
Oct 6, 2020
Member
carolynvs
left a comment
carolynvs
left a comment
There was a problem hiding this comment.
I'm glad you noticed that digest wasn't conformant anymore. Thanks for fixing this!
I just had one question about how the struct name was being turned into a string, then this is good to go.
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
carolynvs
added a commit
to carolynvs/porter
that referenced
this pull request
Nov 5, 2020
This undoes an accidental change from getporter#1308 that changed the manifest field images.NAME.digest to images.NAME.contentDigest. This is a breaking regression for anyone previously using images. There wasn't any need to change the field name in the manifest, we only needed the bundle.json to use the term contentDigest. I have changed the manifest field back to digest, and ensured that the user documentation for that field is up to date. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
3 tasks
carolynvs
added a commit
to carolynvs/porter
that referenced
this pull request
Nov 5, 2020
This undoes an accidental change from getporter#1308 that changed the manifest field images.NAME.digest to images.NAME.contentDigest. This is a breaking regression for anyone previously using images. There wasn't any need to change the field name in the manifest, we only needed the bundle.json to use the term contentDigest. I have changed the manifest field back to digest, and ensured that the user documentation for that field is up to date. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change
digestfield for a mapped image tocontentDigest, per the CNAB core specWhat issue does it fix
Closes #1307
Notes for the reviewer
Checklist
If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇♀️