Revert images.contentDigest back to digest#1358
Merged
carolynvs merged 1 commit intogetporter:mainfrom Nov 5, 2020
Merged
Conversation
vdice
approved these changes
Nov 5, 2020
| @@ -0,0 +1,12 @@ | |||
| --- | |||
Member
There was a problem hiding this comment.
Is this an older/missed blog post? Should it be intro'd in a different PR?
Member
Author
There was a problem hiding this comment.
oops, that's a draft I had on my computer. Sorry about that!
This undoes an accidental change from getporter#1308 that changed the manifest field images.NAME.digest to images.NAME.contentDigest. This is a breaking regression for anyone previously using images. There wasn't any need to change the field name in the manifest, we only needed the bundle.json to use the term contentDigest. I have changed the manifest field back to digest, and ensured that the user documentation for that field is up to date. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
force-pushed
the
undo-image-contentDigest
branch
from
5556c37 to
d56df87
Compare
Member
Author
|
I have removed the extraneous blog post and fixed the testdata for schema.json. Renaming from contentDigest to digest changed the order of the field declarations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change
This undoes an accidental change from #1308 that changed the manifest
field images.NAME.digest to images.NAME.contentDigest. This is a breaking regression for anyone previously using images. There wasn't any need to change the field name in the manifest, we only needed the bundle.json to use the term contentDigest.
I have changed the manifest field back to digest, and ensured that the user documentation for that field is up to date.
What issue does it fix
Closes #1355
Notes for the reviewer
I've made a follow-up issue to look at tag again. #1357
Checklist