Skip to content

fix(lifecycle.go): validate params after pulling bundle from tag#1331

Closed
vdice wants to merge 1 commit intogetporter:mainfrom
vdice:fix/file-param-from-tag
Closed

fix(lifecycle.go): validate params after pulling bundle from tag#1331
vdice wants to merge 1 commit intogetporter:mainfrom
vdice:fix/file-param-from-tag

Conversation

@vdice
Copy link
Copy Markdown
Member

@vdice vdice commented Oct 20, 2020

What does this change

  • Runs parameter validation after pulling a bundle from a tag. In this scenario, the manifest referenced in memory for parameter validation (especially regards those of type file) will only be populated after the bundle is pulled.

Proposed fix for #1320

What issue does it fix

Closes #1320

Notes for the reviewer

Not sure if this is an ideal approach to solving the issue mentioned in #1320 . Other thoughts/ideas?

Checklist

  • Unit Integration Tests
  • Documentation
  • Schema (porter.yaml)

If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Signed-off-by: Vaughn Dice <vadice@microsoft.com>
@carolynvs carolynvs self-assigned this Oct 22, 2020
@carolynvs
Copy link
Copy Markdown
Member

You nerd sniped me into thinking about a larger solution. 😂 I took your unit test and built on top of it here: #1337

@vdice
Copy link
Copy Markdown
Member Author

vdice commented Oct 22, 2020

🎉 The more holistic changes in #1337 definitely are preferred over the bandaid fix presented here. Closing this PR.

@vdice vdice closed this Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using file type parameters from parameterset on published bundle fails with base64 encoding issue

2 participants