fix(lifecycle.go): validate params after pulling bundle from tag#1331
Closed
vdice wants to merge 1 commit intogetporter:mainfrom
Closed
fix(lifecycle.go): validate params after pulling bundle from tag#1331vdice wants to merge 1 commit intogetporter:mainfrom
vdice wants to merge 1 commit intogetporter:mainfrom
Conversation
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Member
|
You nerd sniped me into thinking about a larger solution. 😂 I took your unit test and built on top of it here: #1337 |
Member
Author
|
🎉 The more holistic changes in #1337 definitely are preferred over the bandaid fix presented here. Closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change
Proposed fix for #1320
What issue does it fix
Closes #1320
Notes for the reviewer
Not sure if this is an ideal approach to solving the issue mentioned in #1320 . Other thoughts/ideas?
Checklist
UnitIntegration TestsIf this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇♀️