Refactor when parameters flags are parsed#1337
Merged
carolynvs merged 4 commits intogetporter:mainfrom Oct 27, 2020
Merged
Conversation
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
* ExecuteAction performs any action but uninstall since that operation is performed backwards. * Move resolution of parameters later, when we convert the options into cnab arguments, so that we have the bundle defintion available * Only validate that --param values are in the proper format, PARAM=VALUE Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Since validate modifies the action options, we should store the pointer so that we can retain and changes made. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
3 tasks
Member
|
This looks like a great improvement to me! Definitely in favor of this refactor. We can add a note that this will close #1320 when ready. |
Member
Author
|
/azp run porter |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Okay, the build is working again so this is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change
Parse parameters after bundle is loaded
What issue does it fix
Fixes #1320
Notes for the reviewer
I'd appreciate feedback on if this is an improvement or not. I was trying to have us parse parameters once, and move towards reuse with our new BundleAction interface.
Checklist